Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce tpu- prefix and deprecate it; add tpu as an alias for google #1586

Closed
un-def opened this issue Aug 20, 2024 · 0 comments · Fixed by #1587
Closed

Reintroduce tpu- prefix and deprecate it; add tpu as an alias for google #1586

un-def opened this issue Aug 20, 2024 · 0 comments · Fixed by #1587
Assignees
@un-def

Comments

@un-def
Copy link
Collaborator

un-def commented Aug 20, 2024 •
edited
Loading

Changes in the #1558 PR are not backward compatible, namely the tpu- prefix is no longer supported. There should be a transitional period to let the users update their configurations.

Also, the google vendor is vague, what the user really wants is TPU. Consider making tpu a (preferred) alias for google.
@un-def un-def self-assigned this Aug 20, 2024
un-def added a commit that referenced this issue Aug 20, 2024
@un-def
Reintroduce tpu- prefix; add tpu vendor alias
8a293ae 
Closes: #1586
@un-def un-def mentioned this issue Aug 20, 2024
Merged
@un-def un-def changed the title Reintroduce tpu- prefix and deprecated it; add tpu as an alias for google Reintroduce tpu- prefix and deprecate it; add tpu as an alias for google Aug 20, 2024
@un-def un-def closed this as completed in 75d5f55 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@un-def un-def

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reintroduce tpu- prefix; add tpu vendor alias dstackai/dstack
1 participant
@un-def