Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: dstack server is not compatible with paramiko<3.2 #1982

Closed
un-def opened this issue Nov 12, 2024 · 1 comment · Fixed by #1984
Closed

[Bug]: dstack server is not compatible with paramiko<3.2 #1982

un-def opened this issue Nov 12, 2024 · 1 comment · Fixed by #1984
Assignees
@un-def
Labels
bug Something isn't working fleets ssh-fleets

Comments

@un-def
Copy link
Collaborator

un-def commented Nov 12, 2024 •
edited
Loading

Steps to reproduce

server side:

pip install 'dstack[all]'

pip install 'paramiko<3.2'

pip freeze | grep paramiko
paramiko==3.1.0

pip check
No broken requirements found.

dstack server

client side:

cat fleet.dstack.yml
type: fleet
name: vm-fleet
ssh_config:
  user: debian
  identity_file: ~/.ssh/vm_debian12
  hosts:
    - 192.168.122.75

cat ~/.ssh/vm_debian12.pub
ssh-rsa <KEY_CONTENT> debian@debian

dstack apply -f fleet.dstack.yml

Actual behaviour

See Server logs

Expected behaviour

No response

dstack version

0.18.24

Server logs

[07:26:15] INFO     dstack._internal.server.background.tasks.process_instances:217 Adding ssh instance vm-fleet-0...
           WARNING  dstack._internal.server.background.tasks.process_instances:281 Provisioning instance vm-fleet-0 could not be completed because of the error: Deploy instance raised an error: 'RSAKey' object has no attribute 'fingerprint'

Additional information

No response
@un-def un-def added the bug Something isn't working label Nov 12, 2024
@un-def un-def self-assigned this Nov 12, 2024
@un-def un-def changed the title [Bug]: dstack server is not compatible with paramiko<2.12 [Bug]: dstack server is not compatible with paramiko<3.2 Nov 12, 2024
@un-def
Copy link
Collaborator Author

un-def commented Nov 12, 2024

Affects bot SSH and cloud instance provisioning (SSH via get_paramiko_connection(), CUDO and DataCrunch backends via get_public_key_fingerprint())

un-def added a commit that referenced this issue Nov 12, 2024
@un-def
Set minimum paramiko version to 3.2.0
64bd4da 
`dstack` uses `PKey.fingerprint` property, which was added in 3.2.0:

https://www.paramiko.org/changelog.html

> 3.2.0 2023-05-25
> * [Feature]: `PKey` grew a new `.fingerprint` property [...]

Fixes: #1982
@un-def un-def mentioned this issue Nov 12, 2024
Merged
@un-def un-def closed this as completed in 7a20386 Nov 12, 2024
@peterschmidt85 peterschmidt85 mentioned this issue Nov 14, 2024
Closed
superprat pushed a commit to bahaal-tech/dstack that referenced this issue Dec 20, 2024
@un-def
Set minimum paramiko version to 3.2.0 (dstackai#1984)
7ba9b6e 
`dstack` uses `PKey.fingerprint` property, which was added in 3.2.0:

https://www.paramiko.org/changelog.html

> 3.2.0 2023-05-25
> * [Feature]: `PKey` grew a new `.fingerprint` property [...]

Fixes: dstackai#1982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@un-def un-def

Labels
bug Something isn't working fleets ssh-fleets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set minimum paramiko version to 3.2.0 dstackai/dstack
1 participant
@un-def