-
Notifications
You must be signed in to change notification settings - Fork 183
AWS Capacity Reservation support #1977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
r4victor
merged 21 commits into
dstackai:master
from
timsolovev:issue_1155_aws_capacity_block
Dec 10, 2024
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7fbd659
docs: Update required AWS permissions
tsolovev 9e69bcd
feature: Add reservation support for fleets
tsolovev 18e662a
fix: Remove CLI flags from legacy parser
tsolovev 0e57cb1
Merge remote-tracking branch 'origin/issue_1155_aws_capacity_block' i…
tsolovev f762302
fix: Remove CLI flag from deprecated parsers
tsolovev 0fd0be7
Merge branch 'refs/heads/master' into issue_1155_aws_capacity_block
tsolovev 8a7d5af
feature: Reservation support for runs (service/devenv/task)
tsolovev a7410ac
feature(cli): Reservation support for plans and lists
tsolovev 5647aff
feature(cli): Fix reservation indentation
tsolovev d48d3ec
refactor: Improve function signatures
tsolovev 2b93408
feature(api): Add client backward compatibility for updated run/fleet…
tsolovev 2a447a1
test: Update tests to reflect model changes
tsolovev 002e0ed
test: Update tests to reflect model changes
tsolovev 3a0556e
fix: Patch "InstanceMarketOptions" field for capacity block reservations
tsolovev 57477a1
Merge branch 'master' into issue_1804_aws_efa_ifs
tsolovev da3bd98
fix(aws): Remove currently unsupported p5e. instance from compute filter
tsolovev 5edbd8a
feature(aws): Improve exception handling in get_reservation()
tsolovev db0d4d1
fix(aws): Patch ReservationType field check
tsolovev 2a7e572
Fix KeyError: 'ReservationType'
r4victor da908e6
Minor typing and logging fixes
r4victor ffd6917
Fix reservations when applying fleets
r4victor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,6 +128,10 @@ class InstanceGroupParams(CoreModel): | |
Optional[InstanceGroupPlacement], | ||
Field(description="The placement of instances: `any` or `cluster`"), | ||
] = None | ||
reservation: Annotated[ | ||
Optional[str], | ||
Field(description="The existing reservation for the instances"), | ||
] = None | ||
Comment on lines
+131
to
+134
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just pointing out another client backward incompatibility that we need to address. |
||
resources: Annotated[ | ||
Optional[ResourcesSpec], | ||
Field(description="The resources requirements"), | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I pass
reservation_id
in invalid format (e.g.some_res_1234
), the AWS will errordstack will handle this error and won't crash, but it will be logged with error log level as unexpected AWS errors. It's recommended to catch such expected errors. They can be then re-raised as
ComputeError
.