Update the API re PostMessageOptions vs StructuredSerializeOptions
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatwg/html#3414 introduced the `structuredClone()` API and renamed the `PostMessageOptions` dictionary to `StructuredSerializeOptions`. When implementing this change in Chromium (https://chromium-review.googlesource.com/c/chromium/src/+/3245334), it was decided that, since `structuredClone()` has no use for the `includeUserActivation` parameter, it was better to keep the `StructuredSerializeOptions` as per the spec and incorporate that parameter in a derived interface keeping the old name `PostMessageOptions`. This change updates the proposed IDL of the explainer to reflect these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whatwg/html#3414 introduced the
structuredClone()API and renamed thePostMessageOptionsdictionary toStructuredSerializeOptions. When implementing this change in Chromium (https://chromium-review.googlesource.com/c/chromium/src/+/3245334), it was decided that, sincestructuredClone()has no use for theincludeUserActivationparameter, it was better to keep theStructuredSerializeOptionsas per the spec and incorporate that parameter in a derived interface keeping the old namePostMessageOptions.This change updates the proposed IDL of the explainer to reflect these changes.