Per #1905, correct ssvar logic for skipping the ensemble control member.

dtcenter · Oct 30, 2021 · 07e7d51 · 07e7d51
1 parent 872c50f
commit 07e7d51
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/met/src/libcode/vx_statistics/pair_data_ensemble.cc b/met/src/libcode/vx_statistics/pair_data_ensemble.cc
@@ -652,11 +652,14 @@ void PairDataEnsemble::compute_ssvar() {
    for(i=0; i<o_na.n(); i++) {
 
       // Check if point should be skipped
-      // Exclude the control member from the variance
-      if(skip_ba[i] || i == ctrl_index) continue;
+      if(skip_ba[i]) continue;
 
       // Store ensemble values for the current observation
-      for(j=0, cur.erase(); j<n_ens; j++) cur.add(e_na[j][i]);
+      // Exclude the control member from the variance
+      for(j=0, cur.erase(); j<n_ens; j++) {
+         if(j == ctrl_index) continue;
+         cur.add(e_na[j][i]);
+      }
 
       // Build a variance point
       ens_ssvar_pt pt;