Skip to content

Commit

Permalink
Per #1788, change from name to ss_index_name variable to be a bit mor…
Browse files Browse the repository at this point in the history
…e descriptive in the variable names.
  • Loading branch information
JohnHalleyGotway committed Aug 26, 2021
1 parent 75a3a49 commit 41a3d05
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions met/src/libcode/vx_statistics/met_stats.h
Original file line number Diff line number Diff line change
Expand Up @@ -672,8 +672,8 @@ inline double DMAPInfo::get_beta_value() const { return(beta_value); }

struct SSIDXData {

// Index name
ConcatString name;
// Skill score index name
ConcatString ss_index_name;

// Forecast and reference model names
ConcatString fcst_model;
Expand Down
24 changes: 12 additions & 12 deletions met/src/tools/core/stat_analysis/skill_score_index_job.cc
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ void SSIndexJobInfo::init_from_scratch() {
void SSIndexJobInfo::clear() {

// Initialize
name.clear();
ss_index_name.clear();
fcst_model.clear();
ref_model.clear();
n_term = 0;
Expand All @@ -103,7 +103,7 @@ void SSIndexJobInfo::clear() {

void SSIndexJobInfo::assign(const SSIndexJobInfo &c) {

name = c.name;
ss_index_name = c.ss_index_name;
fcst_model = c.fcst_model;
ref_model = c.ref_model;
n_term = c.n_term;
Expand Down Expand Up @@ -232,7 +232,7 @@ SSIDXData SSIndexJobInfo::compute_ss_index() {
SSIDXData data;

mlog << Debug(3)
<< "Computing " << name << " for " << init_time.n()
<< "Computing " << ss_index_name << " for " << init_time.n()
<< " initialization time(s): " << write_css(init_time) << "\n";

// Compute a skill score for each term
Expand Down Expand Up @@ -286,7 +286,7 @@ SSIDXData SSIndexJobInfo::compute_ss_index() {
else ss_cs << ss;

// Print debug info for each term
mlog << Debug(3) << name << " Term " << i+1
mlog << Debug(3) << ss_index_name << " Term " << i+1
<< ": " << term_cs << ", "
<< n_fcst_lines[i] << " fcst "
<< fcst_job[i].line_type[0] << "->"
Expand Down Expand Up @@ -321,12 +321,12 @@ SSIDXData SSIndexJobInfo::compute_ss_index() {
else ss_avg = ss_sum/weight_sum;

// Store the output data
data.name = name;
data.fcst_model = fcst_model;
data.ref_model = ref_model;
data.init_time = init_time;
data.n_term = n_term;
data.n_vld = n_vld;
data.ss_index_name = ss_index_name;
data.fcst_model = fcst_model;
data.ref_model = ref_model;
data.init_time = init_time;
data.n_term = n_term;
data.n_vld = n_vld;
if(is_bad_data(ss_avg) || is_eq(ss_avg, 1.0)) {
data.ss_index = bad_data_double;
}
Expand All @@ -335,8 +335,8 @@ SSIDXData SSIndexJobInfo::compute_ss_index() {
}

mlog << Debug(3)
<< name << " Weighted Average = " << ss_avg << "\n"
<< name << " Skill Score Value = " << data.ss_index << "\n";
<< ss_index_name << " Weighted Average = " << ss_avg << "\n"
<< ss_index_name << " Skill Score Value = " << data.ss_index << "\n";

return(data);
}
Expand Down
2 changes: 1 addition & 1 deletion met/src/tools/core/stat_analysis/skill_score_index_job.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class SSIndexJobInfo {
SSIndexJobInfo & operator=(const SSIndexJobInfo &);

// Index name
ConcatString name;
ConcatString ss_index_name;

// Forecast and reference model names
ConcatString fcst_model, ref_model;
Expand Down

0 comments on commit 41a3d05

Please sign in to comment.