Update main_v11.1-ref after #2834 (#2844)

* Add user execute permissions to compile script - main_v11.1 (#2740)

* Changing -j to "-j 5" as the recommended value for MAKE_ARGS

* Per #2761, update the MET development environment after upgrading seneca to debian bookworm.

* Per #2761, define runtime python version for testing  rather than using the default version which no longer exists in /usr/local

* Per #2761, fix  setting ci-skip-all

* Per #2761, patching test_util.R to use the -C command line option for ncdiff.

* #2652 Added find_var_by_standard_name and separated common codes to find_xy_vars

* #2757 The SonarQube token and URL are replaced with the pre-defined strings, SONAR_TOKEN_VALUE and SONAR_SERVER_URL

* #2757 Get the email list from the environment variable MET_CRON_EMAIL_LIST__MET (or MET_CRON_EMAIL_LIST)

* #2757 The SonarQube token and URL are replaced by using the environment variable SONAR_TOKEN_VALUE and SONAR_SERVER_URL

* Bugfix #2760 main_v11.1 --enable-python (#2767)

* #2755 Added a header count and checking header count instead of using header id (hid)

* Bugfix #2782 main_v11.1 MASSDEN (#2784)

* Per #2782, update the multiple matching records warning message to include the table number for each record.

* Per #2782, update read_grib2_record_list() to parse the level values and aerosol information correctly for table 4.48.

* Per #2782 tweak variable naming convention.

* Removing ${MAKE_ARGS} in some locations

Removing ${MAKE_ARGS} from "make install" and "make test" for MET.  Removing "met" prefix from met.configure.log because we really need config.log for any detail.  It is confusing to have met.configure.log when that does not contain useful information.

* Adding -lnetcdf -lm to configure_lib_args for NetCDF-CXX

* Feature #2796 main_v11.1 gha node20 (#2798)

* Per #2796, update versions of actions to fix the node 16 to 20 warning message.

* Per #2796, port fixes for artifact name handling over from the develop branch to the main_v11.1 testing workflow. Also add the compilation_options.yml workflow since the workflows are being updated.

* Create 11.1.0_casper

* Recent changes to branch protection rules for the main_vX.Y branches have broken the logic of the update_truth.yml GHA workflow. Instead of submitting a PR to merge main_vX.Y into main_vX.Y-ref directly, use an intermediate update_truth_for_main_vX.Y branch.

* Update the pull request template to include a question about expected impacts to existing METplus Use Cases.

* Bugfix #2833 main_v11.1 azimuth (#2834)

* Per #2833, fix n-1 bug when defining the azimuth delta for range/azimuth grids.

* Per #2833, port fixes over from the bugfix_2833_develop_azimuth branch over to the main_v11.1 branch.

---------

Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>

---------

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@ucar.edu>

.github/pull_request_template.md

@@ -16,9 +16,12 @@ If **yes**, please describe:</br>
 
 - [ ] Do these changes include sufficient testing updates? **[Yes or No]**
 
-- [ ] Will this PR result in changes to the test suite? **[Yes or No]**</br>
+- [ ] Will this PR result in changes to the MET test suite? **[Yes or No]**</br>
 If **yes**, describe the new output and/or changes to the existing output:</br>
 
+- [ ] Will this PR result in changes to existing METplus Use Cases? **[Yes or No]**</br>
+If **yes**, create a new **Update Truth** [METplus issue](https://github.com/dtcenter/METplus/issues/new/choose) to describe them.
+
 - [ ] Please complete this pull request review by **[Fill in date]**.</br>
 
 ## Pull Request Checklist ##

.github/workflows/build_docker_and_trigger_metplus.yml

@@ -18,7 +18,7 @@ jobs:
     name: Handle Docker Image
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Get branch name
         id: get_branch_name
@@ -47,7 +47,7 @@ jobs:
         env:
           GITHUB_CONTEXT: ${{ toJson(github) }}
         run: echo "$GITHUB_CONTEXT"
-      - uses: actions/github-script@v6
+      - uses: actions/github-script@v7
         with:
           github-token: ${{ secrets.METPLUS_BOT_TOKEN }}
           script: |

.github/workflows/compilation_options.yml

@@ -0,0 +1,90 @@
+name: Compilation Options
+
+# Test matrix of MET configuration/compilation options
+
+on:
+
+  # Note that scheduled cron events are run on the default branch.
+  # Enable this schedule when main_v12.0 becomes the default branch.
+
+  #  schedule:
+  #  - cron: '0 7 * * 0''
+
+  push:
+
+    tags:
+      - '**' 
+
+  workflow_dispatch:
+
+env:
+  DOCKERHUB_REPO: dtcenter/met-dev
+
+jobs:
+
+  job_control:
+    name: Determine which jobs to run
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set job controls
+        id: job_status
+        run: .github/jobs/set_job_controls.sh
+        env:
+          commit_msg: ${{ github.event.head_commit.message }}
+          force_tests: ${{ github.event.inputs.force_tests }}
+
+    outputs:
+      met_base_repo: ${{ steps.job_status.outputs.met_base_repo }}
+      met_base_tag: ${{ steps.job_status.outputs.met_base_tag }}
+      branch_name: ${{ steps.job_status.outputs.branch_name }}
+
+  compile:
+    name: Config Opts
+    runs-on: ubuntu-latest
+    needs: job_control
+    strategy:
+      matrix:
+        include:
+          - jobid:  'job1'
+            config: ''
+          - jobid:  'job2'
+            config: '--enable-grib2 --enable-python --enable-lidar2nc --enable-mode_graphics --enable-modis'
+          - jobid:  'job3'
+            config: '--enable-grib2'
+          - jobid:  'job4'
+            config: '--enable-python'
+          - jobid:  'job5'
+            config: '--enable-lidar2nc'
+          - jobid:  'job6'
+            config: '--enable-mode_graphics'
+          - jobid:  'job7'
+            config: '--enable-modis'
+      fail-fast: false
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Create directories to store output
+        run: mkdir -p ${RUNNER_WORKSPACE}/logs
+
+      - name: Compile MET in Docker
+        run: .github/jobs/build_docker_image.sh
+        env:
+          SOURCE_BRANCH: ${{ needs.job_control.outputs.branch_name }}
+          MET_BASE_REPO: ${{ needs.job_control.outputs.met_base_repo }}
+          MET_BASE_TAG: ${{ needs.job_control.outputs.met_base_tag }}
+          MET_CONFIG_OPTS: ${{ matrix.config }}
+
+      - name: Copy all build log files into logs directory
+        if: always()
+        run: cp ${GITHUB_WORKSPACE}/*.log ${RUNNER_WORKSPACE}/logs/
+
+      - name: Upload logs as artifact
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: logs_${{ matrix.jobid }}
+          path: ${{ runner.workspace }}/logs
+          if-no-files-found: ignore
+

.github/workflows/documentation.yml

@@ -18,8 +18,8 @@ jobs:
     name: Build Documentation
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-python@v4
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
         with:
           python-version: '3.8'
       - name: Install dependencies
@@ -29,12 +29,12 @@ jobs:
           python -m pip install -r docs/requirements.txt
       - name: Build docs
         run: ./.github/jobs/build_documentation.sh
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: documentation
           path: artifact/documentation
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: documentation_warnings.log