Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance support for rotated latlon grids and update related documentation. #1574

Closed
20 tasks done
JohnHalleyGotway opened this issue Nov 19, 2020 · 1 comment · Fixed by #1576 or #1579
Closed
20 tasks done

Enhance support for rotated latlon grids and update related documentation. #1574

JohnHalleyGotway opened this issue Nov 19, 2020 · 1 comment · Fixed by #1576 or #1579
Assignees
Labels
component: documentation Documentation issue MET: Library Code requestor: Community General Community type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Nov 19, 2020

Describe the Task

MET #1029 added partial support to MET for rotated lat/lon projections.

A comment from #1029:
Randy finished this for the met-8.0 for GRIB2, MET NetCDF, and the python interface.
May still need to be added for GRIB1 and CF-Compliant NetCDF.

This task is to...

  • Add support for rotated lat/lon grids as grid specification strings.
  • Review/update the documentation, as needed.

I am not able to add support for rotated lat/lon grids for the GRIB1 or NetCDF CF-compliance libraries since I cannot find any sample input data files. Rotated lat/lon is listed as a possible grid type in GRIB1 documentation (https://www.nco.ncep.noaa.gov/pmb/docs/on388/table6.html), but I am unable to run copygb to generate a sample data on that project.

This issues arose via met-help:
https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=97502

Time Estimate

4 hours

Sub-Issues

Consider breaking the task down into sub-issues.
None needed.

Relevant Deadlines

None.

Funding Source

None.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG with George to review PR
  • Select scientist(s) or no scientist required: none scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added component: documentation Documentation issue type: task An actionable item of work priority: high requestor: Community General Community labels Nov 19, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.0 milestone Nov 19, 2020
@JohnHalleyGotway JohnHalleyGotway self-assigned this Nov 19, 2020
@JohnHalleyGotway JohnHalleyGotway changed the title Complete documentation for the rotated latlon projection. Complete support for rotated latlon grids and update related documentation. Nov 19, 2020
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing and removed type: task An actionable item of work labels Nov 19, 2020
@JohnHalleyGotway JohnHalleyGotway changed the title Complete support for rotated latlon grids and update related documentation. Enhance support for rotated latlon grids and update related documentation. Nov 19, 2020
@JohnHalleyGotway
Copy link
Collaborator Author

  • Re-tested GRIB2 and MET NetCDF for rotated lat/lon and confirmed that it works.
  • Re-tested python embedding for rotated lat/lon and confirmed that it works.
  • Consolidated and simplified the documentation of the grid specification string and python embedding dictionaries.
  • Updated grid specification string parsing logic to handled rotated lat/lon grid spec strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue MET: Library Code requestor: Community General Community type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant