Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Grid-Stat to compute SEEPS for gridded observations and write the SEEPS STAT line type. #1943

Closed
7 of 22 tasks
RachelNorth opened this issue Oct 14, 2021 · 4 comments · Fixed by #2344 or #2368
Closed
7 of 22 tasks
Assignees
Labels
MET: Grid-to-Grid Verification MET: Probability Verification priority: blocker Blocker requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: new feature Make it do something new
Milestone

Comments

@RachelNorth
Copy link

RachelNorth commented Oct 14, 2021

Describe the New Feature

The Stable Equitable Error in Probability Space (SEEPS) score is described in Rodwell et al. (2010) and was devised for evaluating quantitative precipitation forecasts against SYNOP gauge data at (but not limited to) station locations. It uses a climatology to account for local variations in rainfall which enables aggregation over otherwise heterogenous locations. Recent work (North et al., 2021) has used a gridded product for calculating the score over both land and sea areas.

This issue will act as an umbrella ticket for the implementation of the gridded score capability.

While Point-Stat writes the SEEPS and SEEPS_MPR line types, Grid-Stat should only write the SEEPS line type. However, recommend also adding support for:

nc_pairs_flag = {
...
    seeps = TRUE;
...
}

There setting the nc_pairs_flag.seeps setting enables some output to be written to the "_pairs.nc" file created by Grid-Stat. At a minimum, it should write the seeps value for each grid point.

Please talk to @RachelNorth to determine if any other columns from the SEEPS_MPR line type should also be written to the "_pairs.nc" NetCDF file.

We do still need to define the columns that should be included in a new SEEPS line type.
MET #1942 left the S12 through PV3 columns set as NA. Work for this issue should actually define their contents.

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

Estimate the amount of work required here.
Unknown

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

Part of Met Office contract, ending August 2022 MET v11.

Funding Source

2799991

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @hsoh-u
  • Select scientist(s) or no scientist required: @RachelNorth

Labels

  • Select component(s)
  • Select priority medium-to-high
  • Select requestor(s) UK Met Office

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@RachelNorth RachelNorth added alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle type: new feature Make it do something new labels Oct 14, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Implement calculation of SEEPS in Grid-Stat Implement calculation of SEEPS for verification against gridded analysis. Oct 14, 2021
@JohnHalleyGotway JohnHalleyGotway added MET: Grid-to-Grid Verification priority: high requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Oct 14, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.1.0 milestone Oct 14, 2021
@RachelNorth RachelNorth added alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: high priority: medium Medium Priority and removed requestor: NOAA/EMC NOAA Environmental Modeling Center priority: high alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone priority: medium Medium Priority labels Oct 14, 2021
@TaraJensen TaraJensen modified the milestones: MET 10.1.0, MET 11.0.0 Jan 6, 2022
hsoh-u pushed a commit that referenced this issue Nov 15, 2022
hsoh-u pushed a commit that referenced this issue Nov 15, 2022
hsoh-u pushed a commit that referenced this issue Nov 15, 2022
hsoh-u pushed a commit that referenced this issue Nov 15, 2022
hsoh-u pushed a commit that referenced this issue Nov 15, 2022
@JohnHalleyGotway JohnHalleyGotway linked a pull request Nov 16, 2022 that will close this issue
15 tasks
hsoh-u pushed a commit that referenced this issue Nov 16, 2022
@hsoh-u hsoh-u moved this from In Progress to Pull Request Review in MET-11.0.0-beta5 (11/20/22) Nov 16, 2022
@hsoh-u hsoh-u closed this as completed Nov 16, 2022
Repository owner moved this from Pull Request Review to Done in MET-11.0.0-beta5 (11/20/22) Nov 16, 2022
@JohnHalleyGotway
Copy link
Collaborator

Testing of MET-11.0.0-beta5 revealed a couple of issues with the SEEPS implementation. Reopening this issue to fix the following:

  • seeps_p1_thresh is included in the Grid-Stat config file but not actually referenced in the code. Update Grid-Stat to use it.
  • The SeepsClimo constructor is called and loads the climo data every time Point-Stat and Grid-Stat are run. This should be changed to only load the data when it is actually needed.

Repository owner moved this from Done to In Progress in MET-11.0.0-beta5 (11/20/22) Dec 5, 2022
hsoh-u pushed a commit that referenced this issue Dec 5, 2022
hsoh-u pushed a commit that referenced this issue Dec 5, 2022
JohnHalleyGotway added a commit that referenced this issue Dec 6, 2022
… MET_SEEPS_GRID_CLIMO_NAME or MET_SEEPS_POINT_CLIMO_NAME environment variables.
hsoh-u added a commit that referenced this issue Dec 6, 2022
Feature #1943 gridstat_seeps: Load SEEPS climo only if SEEPS is enabled
@hsoh-u hsoh-u closed this as completed Dec 6, 2022
Repository owner moved this from In Progress to Done in MET-11.0.0-beta5 (11/20/22) Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Grid-to-Grid Verification MET: Probability Verification priority: blocker Blocker requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: new feature Make it do something new
Projects
No open projects
5 participants