Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store unspecified accumulation interval as 0 rather than bad data #2250

Closed
8 of 22 tasks
JohnHalleyGotway opened this issue Sep 1, 2022 · 0 comments · Fixed by #2251
Closed
8 of 22 tasks

Store unspecified accumulation interval as 0 rather than bad data #2250

JohnHalleyGotway opened this issue Sep 1, 2022 · 0 comments · Fixed by #2251
Assignees
Labels
MET: Configuration priority: medium Medium Priority requestor: UK Met Office United Kingdom Met Office type: bug Fix something that is not working
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Sep 1, 2022

Describe the Problem

This issue arose via a Slack discussion with @mpm-meto. Investigation revealed a slight discrepancy in MET's handling of the accumulation interval value when it is not specified or does not apply. See below for detail.

Expected Behavior

When the accumulation interval does not apply to a given dataset, its value should be stored/reported consistently by MET, regardless of the input file type.

Environment

Describe your runtime environment:
*1. MacOS

To Reproduce

Describe the steps to reproduce the behavior:
1. Run pcp_combine on a GRIB input file:

bin/pcp_combine -add data/sample_fcst/2005080700/wrfprs_ruc13_12.tm00_G212 'name="RH"; level="Z2";' rh.nc

2. Run plot_data_plane with -v 4 on the GRIB input:

bin/plot_data_plane data/sample_fcst/2005080700/wrfprs_ruc13_12.tm00_G212 rh_grib.ps 'name="RH"; level="Z2";' -v 4

3. Run plot_data_plane with -v 4 on the NetCDF output:

bin/plot_data_plane rh.nc rh_nc.ps 'name="RH_Z2"; level="Z2";' -v 4

4: Observe the difference in accumulation interval reported:

DEBUG 4:    accum time: 000000

vs

DEBUG 4:    accum time: NA

These should be consistent.

Only need to fix this in the develop branch, not main_v10.1.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working priority: medium Medium Priority requestor: UK Met Office United Kingdom Met Office MET: Configuration labels Sep 1, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Sep 1, 2022
@JohnHalleyGotway JohnHalleyGotway self-assigned this Sep 1, 2022
JohnHalleyGotway added a commit that referenced this issue Sep 1, 2022
… time attribute is present, report the value as 0 instead of bad data.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Sep 1, 2022 that will close this issue
15 tasks
Repository owner moved this from To Do to Done in MET-11.0.0-beta3 (9/21/22) Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Configuration priority: medium Medium Priority requestor: UK Met Office United Kingdom Met Office type: bug Fix something that is not working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant