Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print ASCII2NC warning message about python embedding support not being compiled #2277

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Sep 23, 2022 · 0 comments · Fixed by #2330
Closed
8 of 20 tasks
Assignees
Labels
MET: Python Embedding priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

Running ascii2nc with python embedding without optional python embedding support being compiled results in this error message:

bin/ascii2nc -format python 'scripts/python/read_ascii_point.py data/sample_obs/ascii/sample_ascii_obs.txt' out.nc
...
ERROR  : set_format() -> unsupported ASCII observation format "python".

Whereas, doing the same with plot_data_plane provides a much better error message:

bin/plot_data_plane PYTHON_NUMPY plot.ps 'name="scripts/python/read_ascii_numpy.py data/python/fcst.txt FCST";'
...
ERROR  : Met2dDataFileFactory::new_met_2d_data_file() -> Support for Python has not been compiled!
ERROR  : To run Python scripts, recompile with the --enable-python option.

Recommend enhancing the ascii2nc error message to make it more clear, and consider reviewing other MET tools that process python point observations as well.

Time Estimate

4 hours.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @JohnHalleyGotway
  • Select scientist(s) or no scientist required: No scientist needed

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: medium Medium Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team MET: Python Embedding labels Sep 23, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Sep 23, 2022
@JohnHalleyGotway JohnHalleyGotway self-assigned this Sep 23, 2022
@JohnHalleyGotway JohnHalleyGotway moved this from Backlog to To Do in MET-11.0.0-beta4 (11/02/22) Sep 23, 2022
@JohnHalleyGotway JohnHalleyGotway moved this from Backlog to Todo in MET-11.0.0-beta5 (11/20/22) Oct 27, 2022
JohnHalleyGotway added a commit that referenced this issue Nov 1, 2022
…not being compiled and update point2grid, plot_point_obs, ascii2nc, point_stat, ensemble_stat, and the vx_data2d_factory to call it.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Nov 2, 2022 that will close this issue
15 tasks
@JohnHalleyGotway JohnHalleyGotway moved this from Todo to Pull Request Review in MET-11.0.0-beta5 (11/20/22) Nov 2, 2022
Repository owner moved this from Pull Request Review to Done in MET-11.0.0-beta5 (11/20/22) Nov 3, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Print a warning message in ASCII2NC about python embedding support not being compiled Print ASCII2NC warning message about python embedding support not being compiled Nov 20, 2022
@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Jan 25, 2023
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Python Embedding priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants