Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax Point-Stat and Ensemble-Stat logic for the configuration of message_type_group_map #2362

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Dec 1, 2022 · 0 comments · Fixed by #2365 or #2367
Closed
8 of 20 tasks

Relax Point-Stat and Ensemble-Stat logic for the configuration of message_type_group_map #2362

JohnHalleyGotway opened this issue Dec 1, 2022 · 0 comments · Fixed by #2365 or #2367
Assignees
@JohnHalleyGotway @robdarvell
Labels
MET: Grid-to-Point Verification priority: high High Priority requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Milestone
MET 11.0.0

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

In his testing of MET-11.0.0-beta5, @robdarvell ran into difficulties setting the message_type_group_map setting via the METplus PointStat wrapper. It required him to include entries for SURFACE, LANDSF, and WATERSF. These message type groups are used when the topo_mask and land_mask configuration options are enabled. However, they are always enforced.

To enhance ease of use, modify the logic for enforcing the presence of these definitions. Instead of always requiring their presence, switch to only requiring them when the corresponding config option is enabled.

Time Estimate

2 hours.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @JohnHalleyGotway
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing requestor: UK Met Office United Kingdom Met Office MET: Grid-to-Point Verification priority: high High Priority labels Dec 1, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Dec 1, 2022
JohnHalleyGotway added a commit that referenced this issue Dec 1, 2022
@JohnHalleyGotway
Per #2362, move the checking of SURFACE, LANDSF, and WATERSF message …
97375d9 
…type groups into the PointStatConfInfo::process_geog() function. Only check for these if topo_mask.flag and/or land_mask.flag are true.
JohnHalleyGotway added a commit that referenced this issue Dec 1, 2022
@JohnHalleyGotway
Per #2362, update the topo_mask and land_mask documentation to clarif…
88fb621 
…y when SURFACE/LANDSF/WATERSF must be defined.
JohnHalleyGotway added a commit that referenced this issue Dec 2, 2022
@JohnHalleyGotway
Feature #2362 message_type_group_map (#2365)
05d4a8f
@JohnHalleyGotway JohnHalleyGotway linked a pull request Dec 2, 2022 that will close this issue
Feature #2362 message_type_group_map #2365
Merged
15 tasks
Repository owner moved this from To Do to Done in MET-11.0.0 Pre-Release (12/9/22) Dec 2, 2022
JohnHalleyGotway added a commit that referenced this issue Dec 3, 2022
@JohnHalleyGotway
Per #2362, further refinement of the message_type_group_map settings.…
60bc9c8 
… It is also used in Ensemble-Stat to define the message types for which surface verification logic should be applied. If not defined in the Point-Stat and Ensemble-Stat config files, use default values. However, if topo_mask and land_mask are enabled in Point-Stat, still require that they actually be defined.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Dec 5, 2022 that will close this issue
Feature #2362 message_type_group_map take 2 #2367
Merged
15 tasks
JohnHalleyGotway added a commit that referenced this issue Dec 5, 2022
@JohnHalleyGotway
Feature #2362 message_type_group_map take 2 (#2367)
6c7fd1a
@JohnHalleyGotway JohnHalleyGotway changed the title Relax the logic to only enforce the contents of message_type_group_map when needed. Relax Point-Stat and Ensemble-Stat logic for the configuration of message_type_group_map Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnHalleyGotway JohnHalleyGotway

@robdarvell robdarvell

Labels
MET: Grid-to-Point Verification priority: high High Priority requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Projects
No open projects
MET-11.0.0 Pre-Release (12/9/22)
Status: Done
Milestone
MET 11.0.0
2 participants
@JohnHalleyGotway @robdarvell