Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to using Python 3.10.4 #2421

Closed
6 of 22 tasks
lisagoodrich opened this issue Jan 23, 2023 · 3 comments · Fixed by #2440 or #2480
Closed
6 of 22 tasks

Upgrade to using Python 3.10.4 #2421

lisagoodrich opened this issue Jan 23, 2023 · 3 comments · Fixed by #2440 or #2480
Assignees
Labels
component: external dependency External dependency issue priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Milestone

Comments

@lisagoodrich
Copy link
Contributor

lisagoodrich commented Jan 23, 2023

Describe the Task

Update any code necessary for upgrading to Python 3.10.4. We are taking this action because WCOSS2 is only allowing Python 3.10.4 to be used for operational installations. Therefore, we need to ensure that our next release uses Python 3.10.4.

Please also update .readthedocs.yaml with 3.10.4
Note that we decided NOT to upgrade to 3.10.4 since RTD supports up to 3.8.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
(Assignee please fill this in once you know.)

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

Incorporate in a beta version as soon as possible to ensure there are no problems.

Funding Source

Please ask Tara before starting on this work.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@lisagoodrich lisagoodrich added requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: external dependency External dependency issue requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone priority: high High Priority labels Jan 23, 2023
@lisagoodrich lisagoodrich added this to the MET 11.1.0 milestone Jan 23, 2023
@lisagoodrich lisagoodrich moved this from 📋 Backlog to 🔖 Ready in MET-11.1.0 Development Jan 23, 2023
@georgemccabe georgemccabe linked a pull request Feb 8, 2023 that will close this issue
15 tasks
georgemccabe added a commit that referenced this issue Feb 16, 2023
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
@JohnHalleyGotway
Copy link
Collaborator

I see that PR #2440 was merged and closed. However, I also see that .readthedocs.yaml still references 3.8:

python:
   version: 3.8
   install:
   - requirements: docs/requirements.txt

Should this actually be changed to 3.10.4 as stated in the text of this issue? Or is that not actually a requirement?

@jprestop
Copy link
Collaborator

Minna had looked into this and found that the highest supported version of Python in ReadtheDocs is Python 3.8.
Here is a link to the comment where she mentioned in the corresponding METcalcpy issue:

dtcenter/METcalcpy#270 (comment)

@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in MET-11.1.0 Development Feb 27, 2023
@georgemccabe georgemccabe linked a pull request Mar 1, 2023 that will close this issue
15 tasks
@georgemccabe georgemccabe reopened this Mar 1, 2023
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in MET-11.1.0 Development Mar 1, 2023
@georgemccabe
Copy link
Collaborator

The DockerHub build for the 11.1.0-beta1 release failed. Changes in PR #2480 should fix the issue.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in MET-11.1.0 Development Mar 1, 2023
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: external dependency External dependency issue priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Projects
No open projects
Status: Done
4 participants