Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance MODE to bound check interest_function corner points in the range 0 to 1 #2545

Closed
4 of 22 tasks
j-opatz opened this issue May 16, 2023 · 0 comments · Fixed by #2546
Closed
4 of 22 tasks

Enhance MODE to bound check interest_function corner points in the range 0 to 1 #2545

j-opatz opened this issue May 16, 2023 · 0 comments · Fixed by #2546
Assignees
Labels
component: code cleanup Code cleanup and maintenance issue component: documentation Documentation issue MET: Grid-to-Grid Verification MET: Object Verification Object-based feature Verification priority: medium Medium Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Milestone

Comments

@j-opatz
Copy link
Contributor

j-opatz commented May 16, 2023

Describe the Problem

It was recently discovered that the corner points as defined for use in the interest_function of MODE are boundless. Currently,

 centroid_dist = (
      (            0.0, 1000000 )
      (  60.0/grid_res, 1000000 )
      ( 600.0/grid_res, 0.0 )
   );

would return actual (albeit extremely high) interest values. Similar behavior is found with negative values.

The MODE documentation also states that interest function entries can be defined as algebraic expressions. Looking deeper into the code shows that this is not possible, and MODE will only accept interest function entries defined as piecewise.

Expected Behavior

The expected behavior would be that MODE errors out if a user provides interest function entries whose corners are not bound between 0 and 1. Additionally, there should be no mention of algebraic expression settings for the interest function entries.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@j-opatz j-opatz added type: bug Fix something that is not working component: documentation Documentation issue component: code cleanup Code cleanup and maintenance issue alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle MET: Object Verification Object-based feature Verification labels May 16, 2023
@j-opatz j-opatz added this to the MET 11.1.0 milestone May 16, 2023
@j-opatz j-opatz moved this from 📋 Backlog to 🏗 In progress in MET-11.1.0 Development May 16, 2023
@j-opatz j-opatz removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label May 16, 2023
@JohnHalleyGotway JohnHalleyGotway added priority: medium Medium Priority requestor: METplus Team METplus Development Team MET: Grid-to-Grid Verification type: enhancement Improve something that it is currently doing and removed type: bug Fix something that is not working labels May 17, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Bugfix: Bound MODE interest_function corner points to 0 and 1, update documentation Add bound checking for MODE interest function corner points for the range 0 to 1 May 17, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Add bound checking for MODE interest function corner points for the range 0 to 1 Add bound checking for MODE `interestfunction corner points for the range 0 to 1 May 17, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Add bound checking for MODE `interestfunction corner points for the range 0 to 1 Add bound checking for MODE interest_function corner points for the range 0 to 1 May 17, 2023
JohnHalleyGotway added a commit that referenced this issue May 17, 2023
…ise linear functions, and updated the MODE documentation accordingly.
@JohnHalleyGotway JohnHalleyGotway linked a pull request May 17, 2023 that will close this issue
15 tasks
@JohnHalleyGotway JohnHalleyGotway moved this from 🏗 In progress to 👀 In review in MET-11.1.0 Development May 17, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in MET-11.1.0 Development May 18, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Add bound checking for MODE interest_function corner points for the range 0 to 1 Enhance MODE to bound check interest_function corner points in the range 0 to 1 Jun 13, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance MODE to bound check interest_function corner points in the range 0 to 1 Enhance MODE to bound check interest_function corner points in the range 0 to 1 Jun 13, 2023
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: code cleanup Code cleanup and maintenance issue component: documentation Documentation issue MET: Grid-to-Grid Verification MET: Object Verification Object-based feature Verification priority: medium Medium Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants