Enhance MODE to bound check interest_function
corner points in the range 0 to 1
#2545
Closed
4 of 22 tasks
Labels
component: code cleanup
Code cleanup and maintenance issue
component: documentation
Documentation issue
MET: Grid-to-Grid Verification
MET: Object Verification
Object-based feature Verification
priority: medium
Medium Priority
requestor: METplus Team
METplus Development Team
type: enhancement
Improve something that it is currently doing
Milestone
Describe the Problem
It was recently discovered that the corner points as defined for use in the interest_function of MODE are boundless. Currently,
would return actual (albeit extremely high) interest values. Similar behavior is found with negative values.
The MODE documentation also states that interest function entries can be defined as algebraic expressions. Looking deeper into the code shows that this is not possible, and MODE will only accept interest function entries defined as piecewise.
Expected Behavior
The expected behavior would be that MODE errors out if a user provides interest function entries whose corners are not bound between 0 and 1. Additionally, there should be no mention of algebraic expression settings for the interest function entries.
Environment
Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)
To Reproduce
Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
Branch name:
bugfix_<Issue Number>_main_<Version>_<Description>
Pull request:
bugfix <Issue Number> main_<Version> <Description>
Select: Reviewer(s) and Development issue
Select: Organization level software support Project for the current coordinated release
Select: Milestone as the next bugfix version
Branch name:
bugfix_<Issue Number>_develop_<Description>
Pull request:
bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
The text was updated successfully, but these errors were encountered: