Feature 1184 dryline #1594
Closed
Feature 1184 dryline #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature_1184_dryline
updated the bool calc code to accept && and ||
…her files that are listed ... strange.
for use in multivar (ie, dryline) mode.
Also code to apply the boolean calcuator to a collection of BoolPlanes.
… unit test. Note this doesn't actually run yet, but it will soon. Also, the input sample data has not yet been added to kiowa or dakota.
…with a call to the parse_ascii_file_list() library utility.
Merge branch 'feature_1184_dryline' of https://github.com/dtcenter/MET into feature_1184_dryline
…to feature_1184_dryline
…mmand line argument.
…into feature_1184_dryline
… for a bit more detail.
|
There are still problems. mode segfaults when run with no arguements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Submitting a PR to merge Randy's changes from the feature_1184_dryline branch into develop.
Describe testing already performed for these changes:
Compiled code for this PR on kiowa in:
/d1/projects/MET/MET_pull_requests/met-10.0.0_beta2/feature_1184/MET-feature_1184_dryline_into_develop
Once compiled, I'll run all of the existing unit test which write their output to:
/d1/projects/MET/MET_pull_requests/met-10.0.0_beta2/feature_1184/MET-feature_1184_dryline_into_develop/test_output
Recommend testing for the reviewer to perform, including the location of input datasets:
Review the code changes and new output from the unit tests.
Note that additional future work related to this task are described in:
MET Enhance Multivariate MODE to generate object statistics for each input field requested by the user. #1283 to avoid temp files
MET Add documentation for Multivariate MODE to the MET User's Guide. #1592 for documentation updates
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
New output files generated by new units tests for MODE multivar.
After merging, should the reviewer DELETE the feature branch from GitHub? [No]
Check with Randy before deleting this branch.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone