Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1575 large_diffs #1741

Merged
merged 20 commits into from
Apr 1, 2021
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4307b18
Per #1575, add mpr_column and mpr_thresh entries to all of the Grid-S…
JohnHalleyGotway Mar 28, 2021
42f8fc7
Per #1575, define config strings to be parsed from the config files.
JohnHalleyGotway Mar 28, 2021
bd50708
Per #1575, store col_name_ptr and col_thresh_ptr in PairBase. They ar…
JohnHalleyGotway Mar 28, 2021
688fbbb
Per #1575, add MPR filtering logic to pair_data_point.cc. Include fil…
JohnHalleyGotway Mar 28, 2021
9a76f7a
Per #1575, update point_stat to parse the mpr_column and mpr_thresh c…
JohnHalleyGotway Mar 28, 2021
eaacfaf
Per #1575, updated Grid-Stat to parse mpr_column and mpr_thresh options.
JohnHalleyGotway Mar 28, 2021
2d08c43
Per #1575, update Point-Stat to store mpr_sa and mpr_ta locally and t…
JohnHalleyGotway Mar 28, 2021
cb00ea4
Per #1575, renamed PairDataEnsemble::subset_pairs() to subset_pairs_o…
JohnHalleyGotway Mar 30, 2021
5fc8996
Per #1575, some cleanup, moving check_fo_thresh() utility function fr…
JohnHalleyGotway Mar 30, 2021
94ff6a4
Per #1575, when implementing this for Grid-Stat, I realized that ther…
JohnHalleyGotway Mar 30, 2021
b7913b8
Per #1575, updating pair_data_point.h/.cc to handle the subsetting of…
JohnHalleyGotway Mar 30, 2021
9e3e7d8
Per #1575, rename subset_pairs() to subset_pairs_cnt_thresh() to be a…
JohnHalleyGotway Mar 30, 2021
96076cd
Per #1575, no real changes here. Just reorganizing the location of th…
JohnHalleyGotway Mar 30, 2021
dac057c
Per #1575, make the subset_pairs() utility function a member function…
JohnHalleyGotway Mar 30, 2021
27c257f
Per #1575, need to actually set the mpr_thresh!
JohnHalleyGotway Mar 30, 2021
b228eed
Per #1575, update subset_pairs_mpr_thresh() to make sure the StringAr…
JohnHalleyGotway Mar 30, 2021
d9b27ae
Per #1575, replace PairDataPoint::subset_pairs_mpr_thresh() with a ut…
JohnHalleyGotway Mar 31, 2021
1358c63
Per #1575, add documentation about mpr_column and mpr_thresh.
JohnHalleyGotway Mar 31, 2021
8acc282
Per #1575, mpr_columns can also include CLIMO_CDF.
JohnHalleyGotway Mar 31, 2021
af73fb0
Per #1575, add tests for Grid-Stat and Point-Stat to exercise the mpr…
JohnHalleyGotway Apr 1, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Per #1575, make the subset_pairs() utility function a member function…
… of the PairDataPoint class named subset_pairs_cnt_thresh() and update the application code to call it.
JohnHalleyGotway committed Mar 30, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit dac057ce8dd54c71cdc81f5df833ec32d18bb78c
2 changes: 1 addition & 1 deletion met/src/libcode/vx_statistics/met_stats.cc
Original file line number Diff line number Diff line change
@@ -1207,7 +1207,7 @@ void SL1L2Info::set(const PairDataPoint &pd_all) {
zero_out();

// Apply continuous filtering thresholds to subset pairs
pd = subset_pairs(pd_all, fthresh, othresh, logic);
pd = pd_all.subset_pairs_cnt_thresh(fthresh, othresh, logic);

// Check for no matched pairs to process
if(pd.n_obs == 0) return;
4 changes: 2 additions & 2 deletions met/src/tools/core/ensemble_stat/ensemble_stat.cc
Original file line number Diff line number Diff line change
@@ -1319,7 +1319,7 @@ void process_point_scores() {
shc.set_obs_thresh(conf_info.vx_opt[i].othr_ta[m]);

// Subset pairs using the current obs_thresh
pd = pd_ptr->subset_pairs(conf_info.vx_opt[i].othr_ta[m]);
pd = pd_ptr->subset_pairs_obs_thresh(conf_info.vx_opt[i].othr_ta[m]);

// Continue if there are no points
if(pd.n_obs == 0) continue;
@@ -1779,7 +1779,7 @@ void process_grid_vx() {
shc.set_obs_thresh(conf_info.vx_opt[i].othr_ta[l]);

// Subset pairs using the current obs_thresh
pd = pd_all.subset_pairs(conf_info.vx_opt[i].othr_ta[l]);
pd = pd_all.subset_pairs_obs_thresh(conf_info.vx_opt[i].othr_ta[l]);

// Continue if there are no points
if(pd.n_obs == 0) continue;
12 changes: 10 additions & 2 deletions met/src/tools/core/grid_stat/grid_stat.cc
Original file line number Diff line number Diff line change
@@ -106,6 +106,8 @@
// continuous and probabilistic statistics.
// 050 03/02/20 Halley Gotway Add nc_pairs_var_name and rename
// nc_pairs_var_str to nc_pairs_var_suffix.
// 051 03/28/21 Halley Gotway Add mpr_column and mpr_thresh
// filtering options.
//
////////////////////////////////////////////////////////////////////////

@@ -1829,6 +1831,11 @@ void get_mask_points(const GridStatVxOpt &vx_opt,

if(cmn_ptr && csd_ptr) pd.add_climo_cdf();

// Apply any MPR filters
if(vx_opt.mpr_sa.n() > 0) {
pd = pd.subset_pairs_mpr_thresh(vx_opt.mpr_sa, vx_opt.mpr_ta);
}

return;
}

@@ -1961,8 +1968,9 @@ void do_cnt_sl1l2(const GridStatVxOpt &vx_opt, const PairDataPoint *pd_ptr) {
for(i=0; i<vx_opt.fcnt_ta.n(); i++) {

// Apply continuous filtering thresholds to subset pairs
pd_thr = subset_pairs(*pd_ptr, vx_opt.fcnt_ta[i],
vx_opt.ocnt_ta[i], vx_opt.cnt_logic);
pd_thr = pd_ptr->subset_pairs_cnt_thresh(vx_opt.fcnt_ta[i],
vx_opt.ocnt_ta[i],
vx_opt.cnt_logic);

// Check for no matched pairs to process
if(pd_thr.n_obs == 0) continue;
4 changes: 2 additions & 2 deletions met/src/tools/core/series_analysis/series_analysis.cc
Original file line number Diff line number Diff line change
@@ -1008,8 +1008,8 @@ void do_cnt(int n, const PairDataPoint *pd_ptr) {
}

// Apply continuous filtering thresholds to subset pairs
pd = subset_pairs(*pd_ptr, cnt_info.fthresh, cnt_info.othresh,
cnt_info.logic);
pd = pd_ptr->subset_pairs_cnt_thresh(cnt_info.fthresh, cnt_info.othresh,
cnt_info.logic);

// Check for no matched pairs to process
if(pd.n_obs == 0) continue;