Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Tested the python script from @j-opatz on kiowa to confirm that it was broken but is now fixed. Here's log output from the tests which shows the correct max value now.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
The code for this PR is compiled on kiowa in:
/d1/projects/MET/MET_pull_requests/met-10.0.0_beta5/feature_1753
Please review the code changes and do whatever additional testing you'd like. Please run at verbosity 3 and 4 and notice that at level 4, the C++ code prints the python system command being executed.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
None needed for this change, although we should update the docs for the change pickle to NetCDF temp files.
Do these changes include sufficient testing updates? [Yes]
No additional testing needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone