Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2218 Initialize polar stereographics parameters for ellipsoidal earth #2434

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Feb 2, 2023

Expected Differences

Five parameters are added for ellipsoidal polar stereo graphics projection. They should be initialized at GRIB, GRIB2, NC_MET and NC_PINTERP.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

GHA should be passed with grib or grib2 inputs afer merging back to develop branch

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

I don't have the commands to test this (The example exists at METplus side)

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u changed the title #2218 Initialize polar stereographics parametres for ellipsoial earth #2218 Initialize polar stereographics parameters for ellipsoial earth Feb 2, 2023
@hsoh-u hsoh-u changed the title #2218 Initialize polar stereographics parameters for ellipsoial earth #2218 Initialize polar stereographics parameters for ellipsoidal earth Feb 2, 2023
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good as far as I can tell. The error in the METplus use case had eccentricity set to a very large number, implying that it was not initialized. Once this is merged into develop, the GHA run for the METplus tests that is triggered will show if the error was fixed.

@hsoh-u hsoh-u merged commit d124e2e into develop Feb 2, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Feb 2, 2023
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2218_polar_stereographic branch February 28, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
3 participants