Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
I tested the script on WCOSS2 Acorn, which uses modules to load both the compiler and the python versions. I test the new functionality for both and got successful runs. I tested the script on Cheyenne, which uses modules to load the compiler, but not Python, and got successful runs. I tested the new compiler specification functionality on seneca (with a subset of the script since that compiler doesn't exist on seneca and neither does the module load functionality) using gnu8 for the COMPILER_NAME, as described in this comment from Discussion 2485.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the code changes, if desired. I believe the script has been well tested. Bugs were found and fixed in testing.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [See below]
I have updated the documentation within the script. An overhaul for more and better documentation is needed in the User's Guide and/or the website, but there will be an issue created by @j-opatz with the results from the focus group. I am waiting until that issue is created to revamp the script documentation in the User's Guide and/or the website.
Do these changes include sufficient testing updates? [N/A]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [20230524].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes