Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2552 gtwo #2553

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Feature #2552 gtwo #2553

merged 2 commits into from
Jun 9, 2023

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented May 25, 2023

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Ran the full set of unit tests via this GHA run and confirmed that there are no differences in the output.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  1. Please review the code changes and note the addition of a DEBUG(5) log message that prints out the basin, lead time, and probability value.
  2. Double-check that all GHA tests for this PR (seen on the "Checks" tab) pass with little green checkmarks.
  3. Review the documentation updates.
  4. Potentially test the code for this PR with an NHC shapefile that includes only 2 and 7 day probs. One can be found on this page: https://www.nhc.noaa.gov/gtwo.php?basin=atlc&fdays=7
    And here is the corresponding shapefile: gtwo_shapefiles.zip
    Please let me know if you'd like to test this, and I can compile the code for this PR on seneca.
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]
    No additional tests are needed. The fact that the code changes work successfully for the older 2, 5, 7 day probs means that the changes do work as expected.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Tuesday 6/6/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

JohnHalleyGotway and others added 2 commits May 24, 2023 14:56
…om the dbf shapefile field names rather than assuming 2, 5, and 7 day probabilities in order.
@JohnHalleyGotway
Copy link
Collaborator Author

@KathrynNewman pushing forward this PR review request date 1 week to 6/6/23.

Please let me know if you don't have time to review these changes, and I'll reassign.

@JohnHalleyGotway JohnHalleyGotway merged commit 4178281 into develop Jun 9, 2023
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2552_gtwo branch June 9, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
2 participants