-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2583 ecnt #2825
Merged
Merged
Feature #2583 ecnt #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oerr_cnv, ign_oerr_cor, and dawid_seb.
… for the 5 new ECNT columns
…OERR at the end. Using IGN_CONV_OERR and IGN_CORR_OERR.
…ar() utility function.
…e 5 new stats with the correct inputs.
… ORANK line type.
…ename DS_OERR as DSS, since observation error is not actually involved in its computation.
Closed
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new output columns to the ECNT line type.
IGN_CONV_OERR
andIGN_CORR_OERR
These are only computed when observation error information - specifically the assumed error distribution - is provided via the config file or in the
MET_OBS_ERROR_TABLE
.Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes]
If yes, please describe:
Adds 2 new columns to the existing ECNT line type.
Pull Request Testing
Describe testing already performed for these changes:
Ran
unit_ensemble_stat.xml
and confirmed that theOBS_ERROR
output files are updated as expected. Manually ran Stat-Analysis jobs (-job aggregate -line_type ECNT
and-job aggregate_stat -line_type ORANK -out_line_type ECNT
) to confirm that they produce consistent output.Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please review:
met_test
user inseneca:/d1/projects/MET/MET_pull_requests/met-12.0.0/beta4/MET-feature_2583_ecnt/bin
.Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Updates the output of the existing
OBS_ERROR
unit test inunit_ensemble_stat.xml
.Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Modifies existing output.
Please complete this pull request review by [Mon 3/4/24].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases