-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2023 remove double quotes around keywords #2974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the changes (mostly prior to this PR in working with @lisagoodrich) and ensured that all tests passed. @lisagoodrich thank you for your patience and attention to detail on this issue as we weeded through what was a keyword and what was not. Hopefully, this will make the documentation more clear for the users. I approve this request. @lisagoodrich, I'll go ahead and squash and merge for you.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
John HG provided the below command to run to capture the majority of keywords
The output from this was captured and put into MET issue #2023 removing double quotes (EVERYTHING). It was 49 pages. Since most of the changes were in the config-options file, the data was broken down into 2 separate sheets:
Config options Copy of MET issue #2023 removing double quotes and Everything else Copy of MET issue #2023 removing double quotes. This second sheet only had 9 changes, and most of those were typos, not keyword double quote issues.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please review to make sure that the correct keywords were changed and the typos make sentences easier to read.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [ No]
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [9/20/24]. This is an artificial date.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases