Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #3 v2.0_debian10 #10

Merged
merged 13 commits into from
Feb 9, 2023
Merged

Feature #3 v2.0_debian10 #10

merged 13 commits into from
Feb 9, 2023

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Feb 8, 2023

Pull Request Testing

  • Describe testing already performed for these changes:

Created images on DockerHub (dtcenter/met-base:v2.0_debian10 and dtcenter/met-base-unit-test:v2.0_debian10) and used them to test MET and METplus use cases

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review code changes. We should create a tag/release once this is merged into main

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

Added version history to README

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 2/13/2023.

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe requested a review from jprestop February 8, 2023 19:28
@georgemccabe georgemccabe linked an issue Feb 8, 2023 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating and testing the images. I have reviewed the changes and this looks good to me. Thank you for adding the version history to the README.md file. It's nice to have that there. I approve this request.

@georgemccabe georgemccabe merged commit 85e873b into main Feb 9, 2023
@georgemccabe georgemccabe deleted the feature_3_debian_py310 branch February 9, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the METbaseimage to install Python 3.10 from source
2 participants