Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 407 stratosphere bias plot #410

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

CPKalb
Copy link
Contributor

@CPKalb CPKalb commented Dec 21, 2023

Pull Request Testing

  • Describe testing already performed for these changes:

    Tested the METplus use cases to check that they produce the plots needed

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Check out the following branches of METplus, METcalcpy, METplotpy, and METdataio
    feature_1344_stratosphere_bias of METplus
    feature_342_write_mpr_file METcalcpy
    this branch of METplotpy
    bugfix_247_readnc_no_lon METdataio

Run 2 use cases, s2s/UserScript_fcstGFS_obsERA_StratosphereBias.conf and s2s/UserScript_fcstGFS_obsERA_StratospherePolar.conf. Verify that that the StratosphereBias use case produces 2 plots (GFS_ERA_ME_2018_02_zonal_mean_T.png, and GFS_ERA_ME_2018_02_zonal_mean_U.png), and the StratospherePolar use case produces 4 plots (ME_2018_02_polar_cap_T.png, ME_2018_02_polar_vortex_U.png, RMSE_2018_02_polar_cap_T.png, and RMSE_2018_02_polar_vortex_U.png).

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes

  • Do these changes include sufficient testing updates? [Yes or No]
    ??

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    No

  • Please complete this pull request review by [Fill in date].

    Soon.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@CPKalb CPKalb added this to the Consider for Next Release milestone Dec 21, 2023
@CPKalb CPKalb linked an issue Dec 21, 2023 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully generated the 2 plots from the UserScript_fcstGFS_obsERA_StratosphereBias and the four plots from UserScript_fcstGFS_obsERA_StratospherePolar

@bikegeek bikegeek merged commit 16ac0f8 into develop Jan 4, 2024
5 checks passed
@bikegeek bikegeek deleted the feature_407_stratosphere_bias_plot branch January 4, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plots for Stratosphere Bias and RMSE
2 participants