Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pass in the input directory to TCMPRPlotter instead of finding all tcst files and passing the list #1084

Closed
10 of 21 tasks
georgemccabe opened this issue Aug 16, 2021 · 1 comment
Assignees
Labels
METplus: Configuration METplus: Tropical/Extra-Tropical Cyclone priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Aug 16, 2021

On some machines, the plot_tcmpr.R script fails if too many files are passed in. We need an option to pass in the input directory instead of populating a list of all .tcst files and passing them in.

Describe the Enhancement

The directory could always be passed in instead of finding all of the files, however there is a small fix to the R script that is needed to run properly. Users that are using an older version of MET that does not have this fix will need to pass in the list of files to the script, so an config variable is needed to toggle this setting.

Time Estimate

<1day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

4.1.0 beta2

Funding Source

2788881

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe
Copy link
Collaborator Author

This is a duplicate of #1057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METplus: Configuration METplus: Tropical/Extra-Tropical Cyclone priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

1 participant