Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the plot_tcmpr.R script to support specifying a directory with -lookin. #1872

Closed
9 of 22 tasks
georgemccabe opened this issue Aug 16, 2021 · 0 comments · Fixed by #1873 or #1874
Closed
9 of 22 tasks

Fix the plot_tcmpr.R script to support specifying a directory with -lookin. #1872

georgemccabe opened this issue Aug 16, 2021 · 0 comments · Fixed by #1873 or #1874
Assignees
Labels
MET: Plotting Tools requestor: METplus Team METplus Development Team type: bug Fix something that is not working

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Aug 16, 2021

Describe the Problem

The script calls tc_stat with the -lookin argument. There is an ls command in the script that is used to expand wildcards. However, this fails to expand to the correct path if a directory is provided. On some machines like Hera, the ls command will fail if a large list of files is provided, so the directory must be provided instead of each individual file to run properly.

Expected Behavior

Passing a directory to the script with the -lookin arugment should work properly.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

10.0.1 bugfix and 10.1.0 beta 2

Funding Source

2788881

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@georgemccabe georgemccabe added type: bug Fix something that is not working priority: high requestor: METplus Team METplus Development Team MET: Plotting Tools labels Aug 16, 2021
@georgemccabe georgemccabe added this to the met-10.0.1 (bugfix) milestone Aug 16, 2021
@georgemccabe georgemccabe self-assigned this Aug 16, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Fix failure in plot_tcmpr.R script when a directory is passed in with -lookin Fix the plot_tcmpr.R script to support specifying a directory with -lookin. Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Plotting Tools requestor: METplus Team METplus Development Team type: bug Fix something that is not working
Projects
None yet
1 participant