Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix 1872 plot_tcmpr.R -lookin directory (main_v10.0) #1873

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Aug 16, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

Ran a use case on Hera and confirmed that the script is able to run as expected.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

None needed, this is a very simple fix. If desired, you can test calling the plotter passing in a directory that contains .tcst files with the -lookin argument. It should fail without this fix.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 8/20/2021.

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the met-10.0.1 (bugfix) milestone Aug 16, 2021
@georgemccabe georgemccabe linked an issue Aug 16, 2021 that may be closed by this pull request
22 tasks
@georgemccabe georgemccabe changed the title bugfix 1872 plot_tcmpr.R -lookin directory bugfix 1872 plot_tcmpr.R -lookin directory (main_v10.0) Aug 16, 2021
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this simple change, updating the plot_tcmpr.R script to change "ls -1" to "ls -1d".

@georgemccabe georgemccabe merged commit 521dbb1 into main_v10.0 Aug 16, 2021
@georgemccabe georgemccabe deleted the bugfix_1872_main_v10.0_tcmpr_plotter branch August 16, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the plot_tcmpr.R script to support specifying a directory with -lookin.
2 participants