Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the config settings which support template tag substitution #2157

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue May 1, 2023 · 1 comment
Closed
8 of 21 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: documentation Documentation issue METplus: Configuration priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Task

The #2152 discussion was about where the template tags, such as {valid} can appear in the METplus configuration file settings.

While it is sort of mentioned in the section about observation data under this section, it should really be clearly stated at the top of the Directory and Filename Template Info section.

This issue is to update the METplus User Documentation to clarify this.

Time Estimate

2 hours?

Sub-Issues

Consider breaking the task down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @georgemccabe
  • Select scientist(s) or no scientist required: No scientist needed

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added component: documentation Documentation issue priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work alert: NEED ACCOUNT KEY Need to assign an account key to this issue METplus: Configuration labels May 1, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-5.1.0 milestone May 1, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 📋 Backlog to 🔖 Ready in METplus-Analysis-5.1.0 Development May 1, 2023
georgemccabe added a commit that referenced this issue May 24, 2023
…luded in a _DIR variable instead of requiring that all template tags must go in the corresponding _TEMPLATE variable
georgemccabe added a commit that referenced this issue May 24, 2023
…time window in case tags are set in the dir to search
@georgemccabe georgemccabe moved this from Todo to In Progress in METplus-Wrappers-5.1.0 Development May 24, 2023
@georgemccabe
Copy link
Collaborator

Changes in PR #2187 include a fix to allow filename template tags in _DIR variables, not just _TEMPLATE variables. This was the main source of confusion as to where the filename template tags can be used. Closing this issue because that update is sufficient for resolving the root issue.

@georgemccabe georgemccabe closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in METplus-Wrappers-5.1.0 Development Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: documentation Documentation issue METplus: Configuration priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work
Projects
None yet
Development

No branches or pull requests

2 participants