Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the SeriesAnalysis wrapper to compute gradient statistics #2827

Open
9 of 23 tasks
JohnHalleyGotway opened this issue Dec 11, 2024 · 0 comments · May be fixed by #2835
Open
9 of 23 tasks

Enhance the SeriesAnalysis wrapper to compute gradient statistics #2827

JohnHalleyGotway opened this issue Dec 11, 2024 · 0 comments · May be fixed by #2835
Assignees
Labels
MET: Configuration MET: Gridded Analysis Tools priority: high High Priority reporting: NRL METplus Naval Research Laboratory METplus Project requestor: Navy/NRL Naval Research Laboratory type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

dtcenter/MET#3030 enhances the Series-Analysis tool in MET to compute the gradient statistics that are currently written by the Grid-Stat tool. The work for that issue makes 2 changes to the MET Series-Analysis configuration file:

  1. Adds the gradient dictionary from the Grid-Stat config file to Series-Analysis:
//
// Gradient statistics
// May be set separately in each "obs.field" entry
//
gradient = {
   dx = [ 1 ];
   dy = [ 1 ];
}
  1. Adds a new output_stats.grad entry to request a list of one or more statistics from the GRAD line type:
//
// Statistical output types
//
output_stats = {
...
   grad   = [];
}

This issue is to update the SeriesAnalysis wrapper accordingly with the enhancements.

Note that @KathrynNewman is the scientist working on dtcenter/MET#3030 and would be a good choice to advise on corresponding wrapper updates.

Time Estimate

1 day?

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

Do not charge NRL METplus after 12/30

Funding Source

7730022 NRL METplus

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METplus-Wrappers-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METplus-Wrappers-X.Y.Z version, select the METplus-Wrappers-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: high High Priority requestor: Navy/NRL Naval Research Laboratory MET: Configuration MET: Gridded Analysis Tools reporting: NRL METplus Naval Research Laboratory METplus Project labels Dec 11, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-6.1.0 milestone Dec 11, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🟢 Ready in METplus-Wrappers-6.1.0 Development Dec 11, 2024
georgemccabe added a commit that referenced this issue Dec 13, 2024
…nalysis (and GridStat) wrapper and added output_stats.grad to SeriesAnalysis.
@georgemccabe georgemccabe linked a pull request Dec 13, 2024 that will close this issue
16 tasks
@georgemccabe georgemccabe moved this from 🟢 Ready to 🏗 In progress in METplus-Wrappers-6.1.0 Development Dec 13, 2024
@georgemccabe georgemccabe moved this from 🏗 In progress to 🔎 In review in METplus-Wrappers-6.1.0 Development Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Configuration MET: Gridded Analysis Tools priority: high High Priority reporting: NRL METplus Naval Research Laboratory METplus Project requestor: Navy/NRL Naval Research Laboratory type: enhancement Improve something that it is currently doing
Projects
Status: 🔎 In review
Development

Successfully merging a pull request may close this issue.

3 participants