Enhance Weather Regime driver to output a Time Weather Regime Frequency and mpr file

[CPKalb]

Describe the Enhancement

Enhance the weather regime driver so it computes a time frequency and outputs MET matched pair files. To test, check out feature_950 branch and run the driver (UserScript_obsERA_obsOnly_WeatherRegime.conf)

Time Estimate

3 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

• Compute weather regime frequencies
• Write weather regime classification to a mpr file
• Write weather regime frequencies to a mpr file

Relevant Deadlines

MET 4.1

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy

Enhancement Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of develop.
  Branch name: feature_<Issue Number>_<Description>
• Complete the development and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into develop.
  Pull request: feature <Issue Number> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Linked issues
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Close this issue.

[georgemccabe]

@CPKalb is this issue resolved? If not, can you add a comment of any status updates and move it to the beta2 project?

[CPKalb]

Hi George: The output is working, as of earlier today. I think it can be moved to beta2. However, the major concern at this point is who to get to review the pr. Minna has been doing the reviews of these pr's and she is out for a while. I'll likely be ready in about a day to submit a pr on this (I need to update some documentation). Tina

…

On Mon, Jul 12, 2021 at 5:06 PM George McCabe ***@***.***> wrote: @CPKalb <https://github.com/CPKalb> is this issue resolved? If not, can you add a comment of any status updates and move it to the beta2 project? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#950 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFJHD4UBC47O5GBD2Q5ZOWTTXNYNVANCNFSM46RWPGEA> .

-- ************************************************* Christina Kalb Associate Scientist National Center for Atmospheric Research 3450 Mitchell Lane Boulder, CO 80301 ***@***.*** 303-497-2819 ************************************************* My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

[georgemccabe]

@CPKalb I can review the PR. Let me know when it is ready.

[CPKalb]

I realized 2 things... A new plot was added to plotpy, so probably we have to do that pr for the plotting first. Also, I need to add some new data for this (and remove the old). I'm giving this a shot now.

…

On Tue, Jul 13, 2021 at 7:19 AM George McCabe ***@***.***> wrote: @CPKalb <https://github.com/CPKalb> I can review the PR. Let me know when it is ready. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#950 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFJHD4VIWUB2WYRRP4M4FILTXQ4MNANCNFSM46RWPGEA> .

-- ************************************************* Christina Kalb Associate Scientist National Center for Atmospheric Research 3450 Mitchell Lane Boulder, CO 80301 ***@***.*** 303-497-2819 ************************************************* My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

[CPKalb]

Do you know if some kind of unit tests are required for METplotpy? Minna has handled all of that in the pas Thanks, Tina

…

On Tue, Jul 13, 2021 at 11:11 AM Christina Kalb ***@***.***> wrote: I realized 2 things... A new plot was added to plotpy, so probably we have to do that pr for the plotting first. Also, I need to add some new data for this (and remove the old). I'm giving this a shot now. On Tue, Jul 13, 2021 at 7:19 AM George McCabe ***@***.***> wrote: > @CPKalb <https://github.com/CPKalb> I can review the PR. Let me know > when it is ready. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#950 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFJHD4VIWUB2WYRRP4M4FILTXQ4MNANCNFSM46RWPGEA> > . > -- ************************************************* Christina Kalb Associate Scientist National Center for Atmospheric Research 3450 Mitchell Lane Boulder, CO 80301 ***@***.*** 303-497-2819 ************************************************* My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

-- ************************************************* Christina Kalb Associate Scientist National Center for Atmospheric Research 3450 Mitchell Lane Boulder, CO 80301 ***@***.*** 303-497-2819 ************************************************* My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

[georgemccabe]

I am not sure, @fisherhucar do you know?

[hankenstein2]

I think we can skip if pressed for time or copy similar ones for the other plots. If we skip we can just add another issue to do for beta2 Hank On Tue, Jul 13, 2021 at 12:47 PM Christina Kalb ***@***.***> wrote:

…

Do you know if some kind of unit tests are required for METplotpy? Minna has handled all of that in the pas Thanks, Tina On Tue, Jul 13, 2021 at 11:11 AM Christina Kalb ***@***.***> wrote: > I realized 2 things... A new plot was added to plotpy, so probably we > have to do that pr for the plotting first. Also, I need to add some new > data for this (and remove the old). I'm giving this a shot now. > > On Tue, Jul 13, 2021 at 7:19 AM George McCabe ***@***.***> > wrote: > >> @CPKalb <https://github.com/CPKalb> I can review the PR. Let me know >> when it is ready. >> >> — >> You are receiving this because you were mentioned. >> Reply to this email directly, view it on GitHub >> <#950 (comment) >, >> or unsubscribe >> < https://github.com/notifications/unsubscribe-auth/AFJHD4VIWUB2WYRRP4M4FILTXQ4MNANCNFSM46RWPGEA > >> . >> > > > -- > ************************************************* > Christina Kalb > Associate Scientist > National Center for Atmospheric Research > 3450 Mitchell Lane > Boulder, CO 80301 > ***@***.*** > 303-497-2819 > ************************************************* > > My working day may not be your working day. Please do not feel obliged to > reply to this email outside of your normal working hours. > -- ************************************************* Christina Kalb Associate Scientist National Center for Atmospheric Research 3450 Mitchell Lane Boulder, CO 80301 ***@***.*** 303-497-2819 ************************************************* My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#950 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHAUIKGSGFSQY7IW6SPB4C3TXSC4LANCNFSM46RWPGEA> .

-- -------------------------------------------------------------- Hank Fisher Research Applications Laboratory 303-497-2817 National Center for Atmospheric Research ***@***.*** P.O. Box 3000, Boulder CO 80307-3000 --------------------------------------------------------------

[CPKalb]

Okay. There might have been unit tests for the other 3 plots, which are in the same file, but I'm not sure. Tina On Wed, Jul 14, 2021 at 8:08 AM Hank Fisher ***@***.***> wrote:

…

I think we can skip if pressed for time or copy similar ones for the other plots. If we skip we can just add another issue to do for beta2 Hank On Tue, Jul 13, 2021 at 12:47 PM Christina Kalb ***@***.***> wrote: > Do you know if some kind of unit tests are required for METplotpy? Minna > has handled all of that in the pas > > Thanks, > Tina > > On Tue, Jul 13, 2021 at 11:11 AM Christina Kalb ***@***.***> wrote: > > > I realized 2 things... A new plot was added to plotpy, so probably we > > have to do that pr for the plotting first. Also, I need to add some new > > data for this (and remove the old). I'm giving this a shot now. > > > > On Tue, Jul 13, 2021 at 7:19 AM George McCabe ***@***.***> > > wrote: > > > >> @CPKalb <https://github.com/CPKalb> I can review the PR. Let me know > >> when it is ready. > >> > >> — > >> You are receiving this because you were mentioned. > >> Reply to this email directly, view it on GitHub > >> < #950 (comment) > >, > >> or unsubscribe > >> < > https://github.com/notifications/unsubscribe-auth/AFJHD4VIWUB2WYRRP4M4FILTXQ4MNANCNFSM46RWPGEA > > > >> . > >> > > > > > > -- > > ************************************************* > > Christina Kalb > > Associate Scientist > > National Center for Atmospheric Research > > 3450 Mitchell Lane > > Boulder, CO 80301 > > ***@***.*** > > 303-497-2819 > > ************************************************* > > > > My working day may not be your working day. Please do not feel obliged to > > reply to this email outside of your normal working hours. > > > > > -- > ************************************************* > Christina Kalb > Associate Scientist > National Center for Atmospheric Research > 3450 Mitchell Lane > Boulder, CO 80301 > ***@***.*** > 303-497-2819 > ************************************************* > > My working day may not be your working day. Please do not feel obliged to > reply to this email outside of your normal working hours. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#950 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AHAUIKGSGFSQY7IW6SPB4C3TXSC4LANCNFSM46RWPGEA > > . > -- -------------------------------------------------------------- Hank Fisher Research Applications Laboratory 303-497-2817 National Center for Atmospheric Research ***@***.*** P.O. Box 3000, Boulder CO 80307-3000 -------------------------------------------------------------- — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#950 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFJHD4VTIYLELABEEY7DULDTXWK6ZANCNFSM46RWPGEA> .

-- ************************************************* Christina Kalb Associate Scientist National Center for Atmospheric Research 3450 Mitchell Lane Boulder, CO 80301 ***@***.*** 303-497-2819 ************************************************* My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.