Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 1684 use case HSS s2s #1688

Merged
merged 6 commits into from
Jul 11, 2022
Merged

feature 1684 use case HSS s2s #1688

merged 6 commits into from
Jul 11, 2022

Conversation

j-opatz
Copy link
Contributor

@j-opatz j-opatz commented Jul 6, 2022

Pull Request Testing

  • Describe testing already performed for these changes:
    This is a similar use case to the BSS, CFSv2 s2s use case that was just entered into develop. The use case was checked to be running correctly. The updates that occured from the BSS use case have been merged with this one, so there shouldn't be any conflicting issues.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
    Check that you can run the use case (use the ice_cover environment on Seneca if needed or any with the netcdf4 package), data is under /d1/projects/METplus/METplus_Data, and that documentation looks correct. The build should be fine, with the only errors being new data.
    the new documentation can be looked at here:https://metplus.readthedocs.io/en/feature_1684_usecase_hss_s2s/generated/model_applications/s2s/GridStat_fcstCFSv2_obsGHCNCAMS_MultiTercile.html#sphx-glr-generated-model-applications-s2s-gridstat-fcstcfsv2-obsghcncams-multitercile-py

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:
    As before, a develop-ref update will be required.

  • Please complete this pull request review by [7/11].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@j-opatz j-opatz added this to the METplus-5.0.0 milestone Jul 6, 2022
@j-opatz j-opatz requested a review from CPKalb July 6, 2022 20:12
@j-opatz j-opatz linked an issue Jul 6, 2022 that may be closed by this pull request
24 tasks
@j-opatz j-opatz closed this Jul 7, 2022
@j-opatz j-opatz reopened this Jul 7, 2022
@CPKalb
Copy link
Contributor

CPKalb commented Jul 8, 2022

I couldn't find the documentation for the use case, but it ran successfully for me on seneca

Copy link
Contributor

@CPKalb CPKalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use case ran as expected. Should there be a space between GHCN and CAMS in the documentation?

@j-opatz j-opatz merged commit f9675ca into develop Jul 11, 2022
@georgemccabe georgemccabe deleted the feature_1684_useCase_HSS_s2s branch October 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

New Use Case: CFSv2 tercile probabilities with HSS output
2 participants