Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
This is a similar use case to the BSS, CFSv2 s2s use case that was just entered into develop. The use case was checked to be running correctly. The updates that occured from the BSS use case have been merged with this one, so there shouldn't be any conflicting issues.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Check that you can run the use case (use the ice_cover environment on Seneca if needed or any with the netcdf4 package), data is under /d1/projects/METplus/METplus_Data, and that documentation looks correct. The build should be fine, with the only errors being new data.
the new documentation can be looked at here:https://metplus.readthedocs.io/en/feature_1684_usecase_hss_s2s/generated/model_applications/s2s/GridStat_fcstCFSv2_obsGHCNCAMS_MultiTercile.html#sphx-glr-generated-model-applications-s2s-gridstat-fcstcfsv2-obsghcncams-multitercile-py
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
As before, a develop-ref update will be required.
Please complete this pull request review by [7/11].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes