-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 685 group pytests #1692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oups of tests in automation to speed things up. removed unused imports from tests and removed parenthesis from assert statements when they are not needed
…est' to does not start with 'pytest' to allow groups of pytests
…marker with the 'not <marker>' syntax
…to have run prior to running
… specify more complex marker strings
… tests involve plotting but the other StatAnalysis tests produce output that are used in the plotting tests
…ome of these tests into separate runs
… marker will improve the timing enough
… this logic is desired in the future)
… reports an error if any test fails
…est jobs to run still works as expected
21 tasks
hankenstein2
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything ran well on seneca. I think this will be useful for METplotpy and METcalcpy but might take us a bit to incorporate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary:
Note some changes to the GHA logic are not necessary for the final solution that was implemented, but I left those changes in place because they don't hurt and are necessary if we ever decide to split the pytest job into multiple jobs in the future.
Pull Request Testing
Ensured all tests pass and time to run the pytest job was greatly reduced (from ~30m to ~10m)
Added info to Contributor's Guide about new functionality
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
The test suite should take less time to run, but everything should still pass as usual.
Please complete this pull request review by 7/13/2022.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes