-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix #2026 main_v5.0 StatAnalysis run once per valid time #2027
Bugfix #2026 main_v5.0 StatAnalysis run once per valid time #2027
Conversation
…_ONCE and added logic to set runtime frequency to once per init/valid if LOOP_ORDER=times and start/end times are not equal to warn users that LOOP_ORDER has been deprecated
…looping over init or valid times, set DATE_BEG/END to the run time so that fcst/obs_init/valid_beg/end are set using the YYYYMMDD of the run time (preserves previous behavior)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix was successfully tested by Shannon Shields on Hera on Jan. 26, 2023.
First, GridStat was run to generate GEFS stat files under the following directories (to mimic EVS subseasonal weekly average stat output structure): atmos.20221221, atmos.20221228, atmos.20230104, atmos.20230111, atmos.20230118. A StatAnalysis_evstest.conf file was then created/run to loop over these dates and gather the stat files under the respective GEFS.20221221, GEFS.20221228, GEFS.20230104, GEFS.20230111, and GEFS.20230118 directories. Setting STAT_ANALYSIS_RUNTIME_FREQ = RUN_ONCE_PER_INIT_OR_VALID in the config file allowed the wrapper to loop over each valid time. If this is not set, then the runtime frequency setting defaults to RUN_ONCE, and the user is reminded to set STAT_ANALYSIS_RUNTIME_FREQ to override.
If LOOP_ORDER=times is set and VALID_BEG is not the same as VALID_END, then a warning message appears telling the user to set the runtime frequency:
"WARNING: LOOP_ORDER has been deprecated. Please set STAT_ANALYSIS_RUNTIME_FREQ = RUN_ONCE_PER_INIT_OR_VALID instead."
The config and log files can be found at:
/scratch2/NCEPDEV/stmp1/Shannon.Shields/scripts/s2s/repo_scripts/METplus/StatAnalysis_evstest.conf
/scratch2/NCEPDEV/stmp1/Shannon.Shields/scripts/s2s/cases/logs/StatAnalysis_fcstGEFS_for20230118_runon20230127024434.log
Pull Request Testing
Ran modified StatAnalysis.conf use case to verify that expected values are set. Confirmed all tests pass
Run use case that was not running as expected and confirm that changes have fixed the issue.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
Please complete this pull request review by 01/27/2023.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes