Feature #2460 allow missing input #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files, updated unit tests to match new behavior, added exception handling to series analysis to prevent crash if file does not exist
… template tag to override a config variable on the command line
…list text file even if there is only 1 file found. Use this argument in UserScript wrapper so that the environment variables that contain paths to file list files are consistent in format for use in user scripts
…nd added optional argument to skip clearing input file list
… files are not found
…ean up those functions to return boolean instead of sometimes returning None or a list of files to be consistent
…ermine if a python script is used with always setting file_type
… fail, ci-run-diff
…ecaus there is no truth data - to confirm that the error log merge step behaves properly in this case
…or logs if any of the 'Save error logs' steps ran successfully
…ail, ci-run-diff" This reverts commit ff2d1ca.
… case groups have errors" This reverts commit 8106666.
22 tasks
JohnHalleyGotway
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
I approve of this PR, as soon as we're able to get a clean GHA run of the testing workflow that does not flag any diffs.
Note that I proposed 2 minor edits in the release notes, updating the release date and fixing a typo. I did check all the issue links and confirmed that they do work.
As for the actual code changes, @georgemccabe walked me through them, and they make sense. But with the possibility of unintended consequences, we should get a clean run before merging.
| @@ -30,6 +30,49 @@ When applicable, release notes are followed by the | |||
| `GitHub issue <https://github.com/dtcenter/METplus/issues>`__ number which | |||
| describes the bugfix, enhancement, or new feature. | |||
|
|
|||
| METplus Version 6.0.0 Beta 3 Release Notes (2024-02-07) | |||
There was a problem hiding this comment.
Suggested change
| METplus Version 6.0.0 Beta 3 Release Notes (2024-02-07) | |
| METplus Version 6.0.0 Beta 3 Release Notes (2024-02-08) |
|
|
||
| .. dropdown:: Enhancements | ||
|
|
||
| * Add suport for MET land-mask settings in Point-Stat |
There was a problem hiding this comment.
Suggested change
| * Add suport for MET land-mask settings in Point-Stat | |
| * Add support for MET land-mask settings in Point-Stat |
|
@JohnHalleyGotway, I will fix the typos in the release notes in the PR for creating the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Added unit tests for new capability to allow missing input files and still run without error
Ensured all existing tests and use cases pass
@JohnHalleyGotway and I met to discuss the details of this PR because there are a lot of changes. All tests should pass with no differences.
Review beta3 release notes: https://metplus--2493.org.readthedocs.build/en/2493/Users_Guide/release-notes.html#metplus-version-6-0-0-beta-3-release-notes-2024-02-07
Additional changes should be made after the beta3 release, including adding documentation for the new config variables. I created issue #2492 to complete remaining tasks.
Added and enhanced unit tests
Will this PR result in changes to the test suite? [No]
Please complete this pull request review by 2/7/2024.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes