-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2844 release_guide_dropdowns #2847
Feature #2844 release_guide_dropdowns #2847
Conversation
…se_guide_dropdowns
…se_guide_dropdowns
…se_guide_dropdowns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The METexpress section looks good to me. You're correct that the AWS instructions can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of the METdataio and METviewer release instructions looks good to me. Thank you!
8e2b97e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great, thank you for doing this, @JohnHalleyGotway!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
METcalcpy and METplotpy look good.
Pull Request Testing
Swinging for the fence here. I added
Instructions
dropdowns basically throughout the Release Guide. Replaced what I considered to be overly organized sub-sub-sub sections with bullets instead so they could fit in the dropdown. Preceeded each dropdown with a 1-sentence summary.Describe testing already performed for these changes:
Built locally to confirm that the changes render well with no warnings.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Throughout, I didn't change the content much... basically just the formatting.
Link to RTD documentation: https://metplus.readthedocs.io/en/feature_2844_release_guide_dropdowns/Release_Guide/index.html
@georgemccabe please review the formatting of the METplus and the coordinated release instructions.
@bikegeek please review the formatting of the METcalcpy and METplotpy release instructions.
@jprestop please review the formatting of the METdataio and METviewer release instructions.
@mollybsmith-noaa please review the formatting of the METexpress release instructions. Molly I also note that the AWS instructions COULD BE removed, but wanted to confirm with you first before doing so.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [No]
None needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Fri 12/20/24].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases