Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after #2817 #2848

Merged
merged 1,171 commits into from
Dec 19, 2024
Merged

Update develop-ref after #2817 #2848

merged 1,171 commits into from
Dec 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

#2817 changed the output file name for the s2s_mid_lat/UserScript_fcstGFS_obsERA_Blocking use case
Created by @georgemccabe

georgemccabe and others added 30 commits November 17, 2023 17:31
…quests via apk instead of pip because the pip commands began failing -- see PEP668 https://peps.python.org/pep-0668/ -- also changed scripts to create conda environments for use case tests to install all packages in a single call to mamba instead of individual calls
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
* added pics, updated desc

* add last two imgs
* adding documentation in different sections

* adding grid table section

* fixing links

* grammar updates

* Per #2454, updated sections and wording.

* Per #2454, added a period to the end of a sentence.

* Per #2454, fixing formatting

* Per #2454, updating wording

* adding a section for line breaks in a table

* adding :code: information

* trying to fix warning

* take 2

* take 3 or 4

* maybe fixed

* updating link

* fixing web link again

* web link saga continues

* Changed "ReadTheDocs" to "Read the Docs"

* Updated "main_v" references to be "main_v12.0"

* Removed references to main_v*, replacing with raw RST 

It is not maintainable to have links to branches which will become old.  Since we can avoid it by adding the raw RST in the documentation, I have removed all references to main_v* in favor of placing the raw RST in the documentation.

* Modified the "Code in a Paragraph" section

* Reworded for consistency within the document

* Added back the link for Sphinx code blocks

---------

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…ed for tests can be easily overridden to test changes in a MET PR before merging
* per dtcenter/MET#2796, update versions of actions to prevent deprecated node warnings in GHA runs

* change arguments to workflow dispatch so they are no longer required -- these are not needed to be set when triggering by hand through the web interface
…ge is built on the fly (when PR is coming from fork) then the tag exists, but if not, the image tag is set to <none>
* new docs, files for use case

* new files

* updating to run use case

* updated python libraries, changed test env

* trying new point logic

* added to script for nan removal

* redid Python script to take adv of new MET ability for nans

* Update run status

* removed unused settings
jprestop and others added 26 commits November 21, 2024 08:04
* update existing builds for upcoming coordinated 6.1 (beta1) release

* added template for existing builds for next dev cycle and added it to ignore list

* Update release guide instructions to set the new location of the Existing Builds page on the Downloads page. Update instructions for creating a new existing builds page to instead copy the template and replace values in the develop branch

* added a step to update the development timeline info for an official release

* Updating existing_builds files

* changed Docker Hub to DockerHub

* added step to update the DockerHub info on the Existing Builds page

* change version to official release because RAL-IT doesn't install development releases on RAL machines

---------

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
* marine_and_cryosphere directories

* fixing underlining

* trying to fix warning msg.

* trying to fix warning msg. again

* Removing space before i.e.

* updating medium_range and pbl directories

* deleting empty file

* removing lots of old text

* precipitation files

* removing junk file

* removing extra #

* add return

* updating 3 dirs s2s, space_weather and unstructured_grids

* updating short_range files

* adding tc_and_extra_tc files

* removing defunct -c option

* added dropdown menus for marine_and_cryosphere

* fixing problems and dropdowns for medium_range

* fixing new problems

* dropdowns for pbl and precip

* adding double colons

* Attempting to resolve errors

* dropdowns for s2s and s2s_mjo

* adding dropdowns for short_range files

* final dropdown directories

* Update docs/use_cases/model_applications/marine_and_cryosphere/GridStat_fcstRTOFS_obsGHRSST_climWOA_sst.py

removing note

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

* Apply suggestions from code review

adding all of the suggestions

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

* Update GridStat_fcstRTOFS_obsGHRSST_climWOA_sst.py

ensuring literal include is in dropdown menu

* Update GridStat_fcstRTOFS_obsOSTIA_iceCover.py

ensuring literal include is in dropdown

* ensuring literal include is in dropdown menu

* marine_and_cryosphere MET Configuration dropdown fixes

* remaining dropdown directories for MET Configuration

* Julie changing dropdowns

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

* HEAD needed to be removed

* There are not MET tools used in this use case

* There are no MET tools used in this use case

* Apply suggestions from code review

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

* Per #2741, few small changes

* updates from pull request discussion

* removing space

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

* fixing dropdown

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

* removing bash

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

* update from Julie

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

* Fixing error

* lots of typos

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

* Adding period

* Adding colon

* Added period

* Added period

* Added period

* typos and more

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

---------

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
* exclude metplus/scripts dir from PyCharm project to prevent incorrect duplicate code warnings with files that are sym linked

* to expand on #2772, updating instructions to include note to set tmp directory for apptainer to prevent issues pulling large images that require a lot of temp space

* per #511, add unit test for expected behavior to support comma-separated lists in a command line single config override that should fail until fix is made

* add a test to ensure that the -c argument is properly ignored since it is can be used in old use cases that were created when the argument was required

* per #511, add support for command line single config overrides to include values that are lists. Simplify logic to parse arguments to strip out -c/--config/-config arguments and skip check/error if argument is invalid because it is already handled in the metplus_config setup step that parses the arguments

* added unit test to ensure that an invalid command line argument causes the appropriate failure from run_metplus.py
* adding In Memoriam section

* Changing to "This Coordinated Release is dedicated to" removing version

* adding links

* fixing Randy's link

* Per #2780, change case of words and add comma after year

---------

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
* per #2816, update title of workflow displayed in Actions tab to display the repo that triggered the workflow on workflow_dispatch events. Preserve the behavior of pull_request and push events by displaying the PR title or head commit message respectively

* fix logic for run-name

* Update event info to note that the workflow was triggered manually if the repo/title was not provided. Update description of workflow_dispatch argument to describe what it can be used for when triggering manually. Only run step to build URL to commit that triggered workflow if it was triggered from an external repo

* add optional argument for workflow_dispatch to specify the title of the workflow run

* revert change to repository argument description since title argument was added to handle custom workflow run titles
* per #2814, add documentation to describe how to set a single config variable on the command line

* fixed typos and formatting issues

* move new content to top of chapter and reword intro sentence

* change label and add link to user env var section

* per #2814, added info and examples for single config overrides with a list of values
* Per #2830, skip closing of log handlers for METplusConfig objects that are created for copying values for process list instances so they are not closed before the end of the run.

* remove some output directories after tests are run
… dev release notes. improve naming of drop downs for generating dev release notes to be consistent
…TC web server to be done for the rc1 release instead of after the official release
* resolve some SonarQube complaints

* per #2586, added function with tests to properly parse list of command line arguments that can now contain comma-separated lists that should not be split up into separate items

* add support for {app}_{data_type}_FILE_WINDOW_BEGIN/END, e.g. GEN_VX_MASK_OBS_FILE_WINDOW_BEGIN. This just adds support for an additional variation of the config variable names

* add support for an empty label for input templates

* update wrapper to be consistent with other wrappers wrt finding input files, progress towards #2492. Allow file window range to be specified separately for mask and input files. Other cleanup to move towards consistent wrappers with fewer wrapper-specific overrides of functions like get_command

* update unit tests to align with changes for #2492

* add documentation for config variables that are newly supported to allow file window range to be specified separately for mask and input files

* renamed GEN_VX_MASK_OBS variables to be GEN_VX_MASK_INPUT as suggested by @JohnHalleyGotway in PR review

* fix logic to properly read input files by handling inputs that support multiple inputs with labels (used by GridDiag and UserScript wrappers) and typical inputs (all other wrappers). Prior to this change only input templates that have the FCST or OBS identifier were read properly via get_input_templates
@georgemccabe georgemccabe added this to the METplus-6.1.0 milestone Dec 19, 2024
@georgemccabe georgemccabe merged commit 97aef7f into develop-ref Dec 19, 2024
@georgemccabe georgemccabe deleted the update_develop_8916821b branch December 19, 2024 21:01
@georgemccabe georgemccabe linked an issue Dec 19, 2024 that may be closed by this pull request
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Documentation: Update Scientific Objective Documentation for some S2S Use Cases