Feature 875 poe precip use case #940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… info for probabilistic data
…time info is provided
…read on init without sub and just substitute values for each runtime
… in VAR<n> variables for SeriesAnalysis
…ecip_useCase To properly test use case that needs changes from both branches
…ip_useCase need to test against old fix for climo with new useCase relevant capabilities
21 tasks
…tcenter/METplus into feature_875_POE_precip_useCase
need to fastforward this branch to not fail out with develop merge
…hub.com/dtcenter/METplus into feature_875_POE_precip_useCase" This reverts commit f3ae56c, reversing changes made to c06a9fd.
…METplus into feature_875_POE_precip_useCase
|
Please note that I made a few minor tweaks on this PR:
|
|
Closing this PR because there were issues with merging changes into this branch that we are having difficulty reverting properly. @j-opatz will create a new PR with only the new changes. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
This branch is in active use, necessary for any time POE data is being run through SeriesAnalysis
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
The develop branch has already been merged with this one so it's very close to up-to-date. This is more of a house-keeping PR, just needs to make it to the next Beta
Documentation updates were made in the Glossary, Python Wrappers, and met_tool_wrapper for the use case -- those should be checked for accuracy
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? **[Yes]**Documentation is updated as needed
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
06/04/2021
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes