Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functions to compute logit statistics #145

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

dtch1997
Copy link
Owner

@dtch1997 dtch1997 commented Apr 4, 2024

In order to fairly compare logit-difference-based statistics across different datasets, it is important to record general statistics about the distribution of logits under steering vectors. This PR adds functionality to compute some moment- and quantile-based statistics

Summary by CodeRabbit

  • New Features
    • Enhanced the TokenProb class in the Pipeline with additional attributes and properties for statistical metrics.
    • Introduced new functions to compute statistical moments and quantiles of tensors within the Pipeline class.
    • Utilized torch, scipy, and numpy for testing purposes in the test_pipeline.py file.

Copy link

coderabbitai bot commented Apr 4, 2024

Walkthrough

The changes encompass enhancing the TokenProb class in pipeline.py with additional attributes for statistical metrics and introducing functions to compute moments and quantiles of tensors. The Pipeline class now incorporates these calculations for logits in the generation pipeline.

Changes

File Summary
repepo/core/pipeline.py TokenProb class updated with additional attributes for statistical metrics and properties for logit_max and logit_min. New functions compute_moments and compute_quantiles added. Pipeline class now calculates moments and quantiles for logits.
tests/core/test_pipeline.py Added imports for torch, scipy, and numpy. New functions added for computing moments and quantiles. Modified Pipeline import in repepo.core.pipeline to include compute_moments and compute_quantiles.

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dtch1997 dtch1997 requested a review from chanind April 4, 2024 14:48
@dtch1997 dtch1997 changed the title Add functions to compute logit statistics feat: add functions to compute logit statistics Apr 4, 2024
@dtch1997 dtch1997 merged commit c447864 into main Apr 4, 2024
0 of 2 checks passed
@dtch1997 dtch1997 deleted the logit_statistics branch May 5, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant