Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persona_generalization experiment script #167

Merged
merged 18 commits into from
May 21, 2024

Conversation

dtch1997
Copy link
Owner

@dtch1997 dtch1997 commented May 12, 2024

Summary by CodeRabbit

  • New Features

    • Added a seed setting for random number generation in the get_sampled_persona_prompts function.
    • Introduced functionality for sweeping layers in a specific model configuration for a chatbot application.
    • Added a function to generate a scatter plot comparing in-distribution and out-of-distribution steerability results for persona generalization experiments.
    • Updated string quotations and variable names for consistency in the compare_steerability_between_models.py script.
    • Updated path construction and default parameter values in repepo/paper/utils.py.
  • Bug Fixes

    • Updated test persona descriptions and dataset/formatter names in test_persona_generalization.py.
  • Documentation

    • Added comments and improved readability in various functions across different files.
  • Refactor

    • Refactored functions for consistency and readability in preprocess_results.py.
  • Style

    • Adjusted seaborn theme setting in plot_sweep_layers_result.py.
  • Tests

    • Updated politically conservative persona descriptions to politically liberal in test_persona_generalization.py.
  • Chores

    • Modified import statements and logic in persona_generalization.py.

Copy link

coderabbitai bot commented May 12, 2024

Walkthrough

The recent changes encompass various enhancements across different scripts and modules. These updates include adding new functionalities, adjusting configurations, modifying import statements, and refining plot settings for better visualization. Additionally, changes were made to steerability comparisons between models and persona descriptions for experimental consistency and clarity.

Changes

Files Summary
repepo/experiments Added seed setting for random number generation in get_datasets.py.
repepo/experiments/sweep_qwen_14b_layers.py Changed test_split attribute in QwenSweepLayersConfig.
repepo/experiments/sweep_llama2_7b_layers.py Introduced functionality for sweeping layers in a chatbot model configuration. Updated configurations and declarations.
repepo/steering/plots/plot_sweep_layers_result.py Added setting of seaborn theme to "darkgrid" for plotting sweep layers results.
repepo/experiments/plots/plot_ood_vs_id_persona_generalization_results.py Introduced a new file for generating scatter plots comparing steerability results for persona generalization experiments. Added new functions and global variables.
tests/experiments/test_persona_generalization.py Updated persona descriptions and related names for experimental consistency.
repepo/paper Various changes in scripts like compare_steerability_between_models.py, make_figures_steering_id.py, make_figures_steering_ood.py, preprocess_results.py, and utils.py for improved functionality and consistency.

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Recent Review Details
Commits Files that changed from the base of the PR and between 99199f0 and f42a866.
Files selected for processing (5)
  • repepo/paper/compare_steerability_between_models.py (1 hunks)
  • repepo/paper/make_figures_steering_id.py (2 hunks)
  • repepo/paper/make_figures_steering_ood.py (1 hunks)
  • repepo/paper/preprocess_results.py (3 hunks)
  • repepo/paper/utils.py (1 hunks)

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chanind chanind force-pushed the fix_minor_experiment_script branch from 99199f0 to f42a866 Compare May 21, 2024 04:38
@chanind chanind merged commit 2eb6b62 into main May 21, 2024
4 checks passed
@chanind chanind deleted the fix_minor_experiment_script branch May 21, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants