Relax Python version requirements #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanind
reviewed
Dec 1, 2023
.github/workflows/ci.yaml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| python-version: ["3.9", "3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
This might make CI take forever to run. Maybe we can just run on the oldest and the newest version if we're worried about compatibility? Or even just running on the oldest version is probably sufficient. IMO old versions are where I'd expect things to break since they're missing features in new versions, and new versions are backwards-compatible with old versions.
|
Currently tests are failing on 3.9 because it doesn't support modern type hint syntax. Do we need to support 3.9? It's already 3 years old |
May be causing issues with CI workflow re-using same cache for different python versions Likely doesn't result in much speedup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously required
python <3.11but are relaxing it to allowpython <4Changelog
pyproject.toml,pdm.lockci.yaml