Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes some of the ideas from in #56 and formalizes them in our architecture with tests to make this sort of eval easy moving forward. Specifically, this adds the following:
make_dataset()
changes from @dtch1997 and adds test coverage around the splitting behaviorPipeline.calculate_output_logprobs()
method based on the code in the the Jupyter notebook in Truthful QA benchmark #56, and adds test coverage.MultipleChoiceAccuracyEvaluator
which implements the accuracy calculation from the Jupyter notebook using logprobs within ourBenchmark
framework, including test coverage.This PR also changes our
EvalPrediction
andEvaluator
types to support logprobs. Now, eachEvaluator
must specify if itrequires_generation
orrequires_probs
to indicate to the benchmark what needs to be run. The benchmark will run generation and/or calculate probabilties as required by evaluators.I also moved the
make_dataset()
stuff fromdata/__init__.py
intodata/make_dataset.py
to make it easier to test.