Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caa experiments 2 #80

Merged
merged 13 commits into from
Jan 24, 2024
Merged

Caa experiments 2 #80

merged 13 commits into from
Jan 24, 2024

Conversation

dtch1997
Copy link
Owner

This adds a workflow to reproduce the results and plots in the original CAA repo.

@dtch1997 dtch1997 requested a review from chanind January 24, 2024 18:15
@dtch1997 dtch1997 mentioned this pull request Jan 24, 2024
Closed
@dtch1997
Copy link
Owner Author

dtch1997 commented Jan 24, 2024 •
edited
Loading

@chanind some of the tests fail after I changed the reading template. I skipped these for now in 4127a1e. I had a brief look but I'm unclear on what exactly is being tested, and I'd like to move on with implementing CAA as a script. Is it a problem if I merge the PR without those tests?

@dtch1997 dtch1997 merged commit cca4b29 into main Jan 24, 2024
2 checks passed
@chanind chanind mentioned this pull request Jan 29, 2024
Merged
@dtch1997 dtch1997 deleted the caa-experiments-2 branch January 31, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanind chanind Awaiting requested review from chanind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dtch1997