Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1342 - Update QidianParser.js for new page style #1343

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Kiradien
Copy link
Collaborator

Re-added webnovel chapter title. Removed excess links added at bottom of page.

@dteviot
Copy link
Owner

dteviot commented Jun 11, 2024

@Kiradien

  1. Are you sure that "div.cha-content" should be removed? When I look at https://www.webnovel.com/book/endless-path-infinite-cosmos_11766562205519505/the-beginning-of-the-end.-part-1-2_31586142793028464, this element is wrapping the wanted content, and also inside div.chapter_content. Removing this will remove the wanted content.
  2. I think you missed updating line 56. I think you need to change it to
        content.className = "chapter_content";

… of page.

Changed json population target from cha_content to chapter_content
@Kiradien
Copy link
Collaborator Author

Kiradien commented Jun 11, 2024

@Kiradien

  1. Are you sure that "div.cha-content" should be removed?

I understand the confusion; div.cha-content isn't being removed, but the div.cha-content div.user-links-wrap - space, not comma - it removes just the user-links-wrap class under the cha-content class. This specification may not be necessary currently, however during the transition Qidian had the chapter titles under a .user-links-wrap.

  1. I think you missed updating line 56.

I've changed it; my original logic for leaving it as it was is flawed by line 58. I'm moderately sure it would still work, but haven't seen the json code actually trigger in a long time.

@dteviot dteviot merged commit f1ff96b into dteviot:ExperimentalTabMode Jun 11, 2024
1 check passed
@dteviot
Copy link
Owner

dteviot commented Jun 11, 2024

@Kiradien

D'oh! Thanks.

@Kiradien Kiradien deleted the patch-3 branch June 19, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants