Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Open Flags and Enforcement #246

Open
dthain opened this issue Jan 26, 2019 · 1 comment
Open

File Open Flags and Enforcement #246

dthain opened this issue Jan 26, 2019 · 1 comment

Comments

@dthain
Copy link
Owner

dthain commented Jan 26, 2019

Fix up the use of access flags for open files, in several places:
1 - User programs that call syscall_open are currently passing in magic integers to indicate various file flags. Instead, they should be using KERNEL_FLAGS_READ etc defined in kernel/types.h
2 - Drop FS_FLAGS_READ|WRITE in fs.h
3 - Remember the flags with which a kobject was opened, and reject attempts to write a file not opened with KERNEL_FLAG_WRITE, or to seek on a file not opened with KERNEL_FLAGS_RANDOM

@dsmith47 dsmith47 self-assigned this Feb 5, 2019
@dthain
Copy link
Owner Author

dthain commented Feb 11, 2019

@dsmith47 I'm happy to have you work on any of #230 #238 #246, but don't claim them all at once time, that tends to block up the queue. Claim one, work on it, make a PR, then claim another one...

@dsmith47 dsmith47 removed their assignment Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants