Accept flag without value where `cargo rustc` does a dedicated error message #141

dtolnay · 2022-05-04T21:30:37Z

Before:

$ cargo expand --test
error: The argument '--test <NAME>' requires a value but none was supplied

USAGE:
    cargo expand [OPTIONS] [ITEM]

For more information try --help

After:

$ cargo expand --test
error: "--test" takes one argument.
Available tests:
    compiletest
    test_autotrait
    test_backtrace
    test_boxed
    test_chain
    test_context
    test_convert
    test_downcast
    test_ensure
    test_ffi
    test_fmt
    test_macros
    test_repr
    test_source

error: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases --> src/opts.rs:41:14 | 41 | pub bin: Option<Option<String>>, | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D clippy::option-option` implied by `-D clippy::pedantic` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option error: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases --> src/opts.rs:45:18 | 45 | pub example: Option<Option<String>>, | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option error: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases --> src/opts.rs:49:15 | 49 | pub test: Option<Option<String>>, | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option error: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases --> src/opts.rs:57:16 | 57 | pub bench: Option<Option<String>>, | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option error: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases --> src/opts.rs:79:18 | 79 | pub package: Option<Option<String>>, | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option

dtolnay added 2 commits May 4, 2022 14:26

Accept flag without value where Cargo does a dedicated error message

7cdc9d3

dtolnay merged commit aaa28b5 into master May 4, 2022

dtolnay deleted the minvalues branch May 4, 2022 21:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Accept flag without value where `cargo rustc` does a dedicated error message #141

Accept flag without value where `cargo rustc` does a dedicated error message #141

dtolnay commented May 4, 2022

Accept flag without value where cargo rustc does a dedicated error message #141

Accept flag without value where cargo rustc does a dedicated error message #141

Conversation

dtolnay commented May 4, 2022

Accept flag without value where `cargo rustc` does a dedicated error message #141

Accept flag without value where `cargo rustc` does a dedicated error message #141