Explicitly requesting an instantiation #336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #312 and elsewhere. Supersedes #329. We use the following
impl
syntax to indicate that we'd like the expansion of the ffi mod to include a given instantiation of UniquePtr, even if otherwise not mentioned in any of the extern function signatures:The same also works if the UniquePtr were to be an extern type alias (
type C = path::to::C;
). In that case it's up to the user whether to place the UniquePtr impl in one ffi module or the other, subject to the Rust orphan rule.Closes #236. Closes #312. Closes #329.