Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warning on unknown upper_case_acronyms lint on old clippys #844

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Apr 20, 2021

The clippy::upper_case_acronyms lint is newly introduced in the Clippy that shipped with rustc 1.51.0. When building CXX-generated Rust code with a toolchain older than 1.51.0, this PR avoids a clippy::unknown_clippy_lints warning in the generated code.

warning: unknown clippy lint: clippy::upper_case_acronyms
 --> path/to/bridge.rs:7:1
  |
7 | #[cxx::bridge]
  | ^^^^^^^^^^^^^^
  |
  = note: `#[warn(clippy::unknown_clippy_lints)]` on by default
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unknown_clippy_lints
  = note: this warning originates in an attribute macro (in Nightly builds, run with -Z macro-backtrace for more info)

@dtolnay dtolnay merged commit f8eac57 into master Apr 20, 2021
@dtolnay dtolnay deleted the unknownlint branch April 20, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant