-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental support for enum variant names and discriminant values retrieved from C++ #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional feature based on https://github.com/dtolnay/clang-ast to extract information about shared enums (variant names, discriminant values, repr type) from a serialized Clang AST of the associated C++ headers.
The user-facing change is:
Wiring up an AST dump in a Buck-based build looks something like:
where
clang_ast()
is a simple bzl macro implemented as a genrule that runsclang++ -Xclang -ast-dump=json -fsyntax-only $(location {header}) -I$(location {deps}) -x c++
, andrust_cxx_bridge
is like tools/buck/rust_cxx_bridge.bzl.This is experimental for now but opens up some interesting possibilities, such as:
type Kind = Trivial
forextern "C++"
types which have a trivial definition, thereby making them available by value in Rust