Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 128bit numbers #24

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Add support for 128bit numbers #24

merged 2 commits into from
Aug 22, 2018

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Aug 21, 2018

Hi there!

I ran into a case recently where I needed 128bit number support in erased-serde so have taken a stab at implementing it here.

I've gone with a conservative route of defaulting the conditional trait methods even though I think the de::Visitor is actually private. This should be a non-breaking change.

Please let me know if you'd like me to throw a test case in there somewhere or if there's anything you'd like done differently.

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

None of the three traits Serializer, Deserializer, Visitor are possible to implement outside of this crate so you can remove the default impls of the new methods.

@KodrAus
Copy link
Contributor Author

KodrAus commented Aug 22, 2018

Done 👍 It also turns out I'd missed a few of the impl blocks the first time around

@dtolnay dtolnay merged commit 774a1a8 into dtolnay:master Aug 22, 2018
@dtolnay
Copy link
Owner

dtolnay commented Aug 22, 2018

Nicely done. I published 0.3.6 containing this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants