Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenBSD #90

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Add support for OpenBSD #90

merged 3 commits into from
Jun 5, 2024

Conversation

lcheylus
Copy link
Contributor

@lcheylus lcheylus commented Jun 5, 2024

  • Add support for OpenBSD, same as for FreeBSD

  • Build OK on OpenBSD current/amd64 (future version 7.6) with Rust 1.78.0

  • Tests OK with RUSTFLAGS="-Clink-arg=-fuse-ld=lld -Clink-arg=-z -Clink-arg=nostart-stop-gc"
    See "The encapsulation symbol needs to be retained under --gc-sections properly" #49 for explanations

  • Add OpenBSD support in README.md

  • Need to disable test_empty in tests/distributed_slice.rs: unable to solve errors

$ $ RUSTFLAGS="-Clink-arg=-fuse-ld=lld -Clink-arg=-z -Clink-arg=nostart-stop-gc" cargo test
(...)
    ld.lld: error: undefined symbol: __start_linkme_EMPTY
(...)
    ld.lld: error: undefined symbol: __stop_linkme_EMPTY

Fix #89

lcheylus added 3 commits June 5, 2024 12:49
- Add support for OpenBSD, same as for FreeBSD
- Tests OK with RUSTFLAGS="-Clink-arg=-fuse-ld=lld -Clink-arg=-z -Clink-arg=nostart-stop-gc"
See dtolnay#49 for explanations

Signed-off-by: Laurent Cheylus <foxy@free.fr>
test_empty fails on OpenBSD with Rust 1.78

$ RUSTFLAGS="-Clink-arg=-fuse-ld=lld -Clink-arg=-z -Clink-arg=nostart-stop-gc" cargo test
ld.lld: error: undefined symbol: __start_linkme_EMPTY
(...)
ld.lld: error: undefined symbol: __stop_linkme_EMPTY

Signed-off-by: Laurent Cheylus <foxy@free.fr>
Signed-off-by: Laurent Cheylus <foxy@free.fr>
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 9270033 into dtolnay:master Jun 5, 2024
14 checks passed
@lcheylus lcheylus deleted the openbsd branch June 5, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for OpenBSD
2 participants